Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: Moead-framework : a modular MOEA/D python framework #2974

Closed
39 of 40 tasks
whedon opened this issue Jan 20, 2021 · 87 comments
Closed
39 of 40 tasks

[REVIEW]: Moead-framework : a modular MOEA/D python framework #2974

whedon opened this issue Jan 20, 2021 · 87 comments
Assignees
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@whedon
Copy link

whedon commented Jan 20, 2021

Submitting author: @geoffreyp (Geoffrey Pruvost)
Repository: https://github.com/moead-framework/framework
Branch with paper.md (empty if default branch):
Version: 1.0
Editor: @melissawm
Reviewers: @sjvrijn, @chkoar
Archive: 10.5281/zenodo.7152178

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a81ea21d0358e013000b0b3b926bd4ba"><img src="https://joss.theoj.org/papers/a81ea21d0358e013000b0b3b926bd4ba/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a81ea21d0358e013000b0b3b926bd4ba/status.svg)](https://joss.theoj.org/papers/a81ea21d0358e013000b0b3b926bd4ba)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@sjvrijn & @chkoar, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @melissawm know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Review checklist for @sjvrijn

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@geoffreyp) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @chkoar

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@geoffreyp) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
@whedon
Copy link
Author

whedon commented Jan 20, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @sjvrijn, @chkoar it looks like you're currently assigned to review this paper 🎉.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 20, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TEVC.2008.925798 is OK
- 10.1109/TEVC.2007.892759 is OK
- 10.1109/CEC.2009.4982949 is OK
- 10.1145/3377930.3390149 is OK
- 10.1007/978-3-030-43680-3_9 is OK
- 10.18637/jss.v092.i06 is OK
- 10.1109/ACCESS.2020.2990567 is OK
- 10.21105/joss.02338 is OK
- 10.1145/2739482.2768462 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Jan 20, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@melissawm
Copy link

👋🏼 @geoffreyp @sjvrijn @chkoar this is the review thread for the paper. All of our communications will happen here from now on.

Both reviewers have checklists at the top of this thread with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#2974 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use Whedon (our bot) to set automatic reminders if you know you'll be away for a known period of time.

Please feel free to ping me (@melissawm) if you have any questions/concerns.

@melissawm
Copy link

Hello, folks! @chkoar @sjvrijn @geoffreyp I see some progress in the checkboxes, let me know if there's anything I can help you with. Thanks!

@whedon
Copy link
Author

whedon commented Feb 3, 2021

👋 @sjvrijn, please update us on how your review is going.

@whedon
Copy link
Author

whedon commented Feb 3, 2021

👋 @chkoar, please update us on how your review is going.

@chkoar
Copy link

chkoar commented Feb 4, 2021

Hey @melissawm, I hope that by Monday I will have completed the review.

@chkoar
Copy link

chkoar commented Feb 6, 2021

Hey @melissawm, I created a couple of issues in the software repo.
I'll wait the authors response in order to continue my review report.

@geoffreyp
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 10, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@geoffreyp
Copy link

Hello @chkoar and @sjvrijn,
I answered your issues and push the new release(0.5.8) of the framework with your comments and tips, thank you!

I move the documentation in the same repository, the new URL is: https://moead-framework.github.io/framework/

@chkoar
Copy link

chkoar commented Feb 11, 2021

@geoffreyp please try to address the raised issues atomically. Unrelated changes might slow down the review process. Thanks.

@geoffreyp
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@geoffreyp
Copy link

geoffreyp commented Oct 6, 2022

Hello @melissawm, here are the requested information :

@melissawm
Copy link

@editorialbot set 10.5281/zenodo.7152178 as archive

@editorialbot
Copy link
Collaborator

Done! Archive is now 10.5281/zenodo.7152178

@melissawm
Copy link

@editorialbot set 1.0 as version

@editorialbot
Copy link
Collaborator

Done! version is now 1.0

@melissawm
Copy link

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TEVC.2008.925798 is OK
- 10.1109/TEVC.2007.892759 is OK
- 10.1109/CEC.2009.4982949 is OK
- 10.1145/3377930.3390149 is OK
- 10.1007/978-3-030-43680-3_9 is OK
- 10.18637/jss.v092.i06 is OK
- 10.1109/ACCESS.2020.2990567 is OK
- 10.21105/joss.02338 is OK
- 10.1145/2739482.2768462 is OK
- 10.1109/SSCI.2016.7850138 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3625, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Oct 16, 2022
@arfon
Copy link
Member

arfon commented Oct 16, 2022

@geoffreyp – I found a couple of minor typos in your paper here: moead-framework/framework#79

@arfon
Copy link
Member

arfon commented Oct 17, 2022

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TEVC.2008.925798 is OK
- 10.1109/TEVC.2007.892759 is OK
- 10.1109/CEC.2009.4982949 is OK
- 10.1145/3377930.3390149 is OK
- 10.1007/978-3-030-43680-3_9 is OK
- 10.18637/jss.v092.i06 is OK
- 10.1109/ACCESS.2020.2990567 is OK
- 10.21105/joss.02338 is OK
- 10.1145/2739482.2768462 is OK
- 10.1109/SSCI.2016.7850138 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@geoffreyp
Copy link

Thanks @arfon, it is fixed

@editorialbot
Copy link
Collaborator

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3629, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@arfon
Copy link
Member

arfon commented Oct 17, 2022

@editorialbot accept

@editorialbot
Copy link
Collaborator

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@editorialbot
Copy link
Collaborator

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.02974 joss-papers#3630
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.02974
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Oct 17, 2022
@arfon
Copy link
Member

arfon commented Oct 17, 2022

@sjvrijn, @chkoar – many thanks for your reviews here and to @melissawm for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@geoffreyp – your paper is now accepted and published in JOSS ⚡🚀💥

@arfon arfon closed this as completed Oct 17, 2022
@editorialbot
Copy link
Collaborator

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02974/status.svg)](https://doi.org/10.21105/joss.02974)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02974">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02974/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02974/status.svg
   :target: https://doi.org/10.21105/joss.02974

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

8 participants