Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PyPO: a Python package for Physical Optics #5471

Closed
editorialbot opened this issue May 17, 2023 · 28 comments
Closed

[PRE REVIEW]: PyPO: a Python package for Physical Optics #5471

editorialbot opened this issue May 17, 2023 · 28 comments
Assignees

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 17, 2023

Submitting author: @arend95 (Arend Moerman)
Repository: https://github.com/PyPO-dev/PyPO
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @danielskatz
Reviewers: @MikeHughesKent, @brandondube
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/baa668ad384488715dbfb1a540fb67fd"><img src="https://joss.theoj.org/papers/baa668ad384488715dbfb1a540fb67fd/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/baa668ad384488715dbfb1a540fb67fd/status.svg)](https://joss.theoj.org/papers/baa668ad384488715dbfb1a540fb67fd)

Author instructions

Thanks for submitting your paper to JOSS @arend95. Currently, there isn't a JOSS editor assigned to your paper.

@arend95 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels May 17, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.13 s (633.2 files/s, 174201.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          53           2605           2635           8141
C/C++ Header                    15            781           1422           2738
CUDA                             2            411            701           1240
C++                              4            246            661            776
Markdown                         5             23              0            154
CSS                              1              7              3            119
TeX                              1              7              0             93
CMake                            1             16              1             33
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            83           4097           5427          13312
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 630

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10909-022-02888-5 is OK
- 10.1117/12.551391 is OK
- 10.1117/12.925230 is OK
- 10.21105/joss.01352 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

@kyleniemeyer
Copy link

Hi @arend95, we'll use this pre-review issue to assign an editor and find reviewers - and also fix any initial issues with the submission.

Can you change the affiliation for the coauthor with multiple from [1,2] to "1, 2"?

@kyleniemeyer
Copy link

@editorialbot invite @danielskatz as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@danielskatz
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @danielskatz is now the editor

@danielskatz
Copy link

@arend95 - once the paper compiles, we can start looking for reviewers.

Please follow the example paper and note that you can click on the error above to find out more about it. Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@arendMoerman
Copy link

Hi all, thanks for pointing out this mistake!

@arendMoerman
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @alvesjnr, @MikeHughesKent, @brandondube, @aquilesC, @DiegoJRR - would a couple of you be willing to review this submission for JOSS?

@MikeHughesKent
Copy link

@danielskatz Yes I can take a look at this one.

@danielskatz
Copy link

Thanks @MikeHughesKent - I'll add you to the system, but we won't start the review until we get at least one more reviewer as well.

@danielskatz
Copy link

@editorialbot add @MikeHughesKent as reviewer

@editorialbot
Copy link
Collaborator Author

@MikeHughesKent added to the reviewers list!

@brandondube
Copy link

Yes, I can perform a review

@danielskatz
Copy link

Thanks @brandondube - I'll add you, and see if anyone else wants to join, then start the review tomorrow either way

@danielskatz
Copy link

@editorialbot add @brandondube as reviewer

@editorialbot
Copy link
Collaborator Author

@brandondube added to the reviewers list!

@danielskatz
Copy link

ok, let's go ahead and get started

@danielskatz
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5478.

@alvesjnr
Copy link

Hi,

I'm sorry but I don't have the bandwidth at the moment to review.

If the review extend past the next two weeks (05/Jun) I can join starting from this date.

@danielskatz
Copy link

that's fine - as you saw, we found 2 reviewers which should be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants