Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SOAP: A Python package for calculating the properties of galaxies and halos formed in cosmological simulations #7851

Open
editorialbot opened this issue Feb 25, 2025 · 9 comments
Labels
pre-review Python Shell Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @robjmcgibbon (Robert McGibbon)
Repository: https://github.com/SWIFTSIM/SOAP
Branch with paper.md (empty if default branch): soap_runtime
Version: v1.0
Editor: Pending
Reviewers: Pending
Managing EiC: Warrick Ball

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/6b5f4bdcadb76ef9bb50d97f897989d9"><img src="https://joss.theoj.org/papers/6b5f4bdcadb76ef9bb50d97f897989d9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/6b5f4bdcadb76ef9bb50d97f897989d9/status.svg)](https://joss.theoj.org/papers/6b5f4bdcadb76ef9bb50d97f897989d9)

Author instructions

Thanks for submitting your paper to JOSS @robjmcgibbon. Currently, there isn't a JOSS editor assigned to your paper.

@robjmcgibbon if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Feb 25, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1093/mnras/stu2058 is OK
- 10.1093/mnras/stad2419 is OK
- 10.1093/mnras/stad2540 is OK
- 10.1093/mnras/stae922 is OK
- 10.1093/mnras/stx2792 is OK
- 10.1088/0004-637X/762/2/109 is OK
- 10.1046/j.1365-8711.2001.04912.x is OK
- 10.1017/pasa.2019.12 is OK
- 10.21105/joss.02430 is OK
- 10.1111/j.1365-2966.2005.09655.x is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Assessing subhalo finders in cosmological hydrodyn...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- https://doi.org/10.1016/j.jpdc.2005.03.010 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.22 s (675.1 files/s, 169514.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          74           3190           6710          21619
YAML                            11             45             74           2539
TeX                             32            146              0            759
Bourne Shell                    24            221            539            468
Markdown                         5            125              0            464
Text                             1              0              0             12
-------------------------------------------------------------------------------
SUM:                           147           3727           7323          25861
-------------------------------------------------------------------------------

Commit count by author:

   315	John Helly
   151	Bert Vandenbroucke
    80	robjmcgibbon
    26	Joey Braspenning
    10	Moyoxkit
     5	Jeger Broxterman
     5	Matthieu Schaller
     2	Victor J. Forouhar Moreno

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with affiliations for Matthieu Schaller, perhaps the affiliations index need quoting?.

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1217

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU Lesser General Public License v3.0 (Check here for OSI approval)

@robjmcgibbon
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

CosmicProfiles: A Python package for radial profiling of finitely sampled dark matter halos and galaxies
Submitting author: @tibordome
Handling editor: @adonath (Active)
Reviewers: @benediktdiemer, @phil-mansfield
Similarity score: 0.7453

Paicos: A Python package for analysis of (cosmological) simulations performed with Arepo
Submitting author: @tberlok
Handling editor: @JBorrow (Active)
Reviewers: @ttricco, @kyleaoman
Similarity score: 0.7298

21cmFAST v3: A Python-integrated C code for generating 3D realizations of the cosmic 21cm signal.
Submitting author: @steven-murray
Handling editor: @dfm (Active)
Reviewers: @sambit-giri, @sultan-hassan
Similarity score: 0.7296

AstroPaint: A Python Package for Painting Halo Catalogs into Celestial Maps
Submitting author: @syasini
Handling editor: @harpolea (Retired)
Reviewers: @AshKelly, @zpace
Similarity score: 0.7239

swift-emulator: A Python package for emulation of simulated scaling relations
Submitting author: @Moyoxkit
Handling editor: @dfm (Active)
Reviewers: @JDonaldM, @kstoreyf
Similarity score: 0.7229

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python Shell Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

2 participants