[REVIEW]: MCSD: A MATLAB Tool for Monte-Carlo Simulations of Diffusion in biological Tissues

[whedon]

Submitting author: @davidnsousa (David Sousa)
Repository: https://github.com/davidnsousa/mcsd
Version: v0.1.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @nnadeau, @mwacaan
Archive: 10.5281/zenodo.1471546

Status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/887b1b7792d59ea6582a4700f8ff98ad"><img src="http://joss.theoj.org/papers/887b1b7792d59ea6582a4700f8ff98ad/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/887b1b7792d59ea6582a4700f8ff98ad/status.svg)](http://joss.theoj.org/papers/887b1b7792d59ea6582a4700f8ff98ad)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@nnadeau & @mwacaan, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

1. Make sure you're logged in to your GitHub account
2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @nnadeau

Conflict of interest

• As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

• I confirm that I read and will adhere to the JOSS code of conduct.

General checks

• Repository: Is the source code for this software available at the repository url?
• License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
• Version: Does the release version given match the GitHub release (v0.1.0)?
• Authorship: Has the submitting author (@davidnsousa) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• Authors: Does the paper.md file include a list of authors with their affiliations?
• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Review checklist for @mwacaan

Conflict of interest

• As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

• I confirm that I read and will adhere to the JOSS code of conduct.

General checks

• Repository: Is the source code for this software available at the repository url?
• License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
• Version: Does the release version given match the GitHub release (v0.1.0)?
• Authorship: Has the submitting author (@davidnsousa) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• Authors: Does the paper.md file include a list of authors with their affiliations?
• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @nnadeau, it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

2. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

👉 Check article proof 📄 👈

[Kevin-Mattheus-Moerman]

@nnadeau, @mwacaan this is where the review happens. Let me know if you have questions.

[Kevin-Mattheus-Moerman]

@mfroeling want to help review this package?

[engnadeau]

@davidnsousa how did Hugo A. Ferreira contribute? They are not listed in any commit history.

[davidnsousa]

@nnadeau Hugo A. Ferreira contributed to the program, tutorial, replication script and paper, but he did not contribute directly through the GitHub platform to the package maintenance. I took full responsibility on the repository.

[engnadeau]

@davidnsousa everything looks good to me! :)

Just fix the following:

• Is mcsd being used or has been used in research? davidnsousa/mcsd#13
• Use TravisCI, CircleCI, GitlabCI, etc for checking PRs davidnsousa/mcsd#14
• Fixed syntax davidnsousa/mcsd#12
• Test 4 doesn't complete in reasonable amount of time davidnsousa/mcsd#11
• Split tests davidnsousa/mcsd#10
• Make master a protected branch davidnsousa/mcsd#15

[davidnsousa]

@nnadeau thank you :) these issues are all fixed!

[engnadeau]

@davidnsousa I’m at a conference in Madrid right now, but I’ll finalize everything when I’m back!

[Kevin-Mattheus-Moerman]

@mwacaan can you remind us when you are able to work on this review? Thanks! 🤖

[mwacaan]

@davidnsousa: in the paper you say: 'no simple and free open-source tools were designed and made available for researchers in this field to test their basic predictions.'
I know of at least the Camino package for Monte Carlo diffusion simulations (http://camino.cs.ucl.ac.uk/index.php?n=Tutorials.MCSimulator), but there may/must be more. Can you cite available packages in the pdf?

[Kevin-Mattheus-Moerman]

@mwacaan Thanks for your review comments. If you want to open any issues for this submission please do so here: https://github.com/davidnsousa/mcsd/issues. Thanks 🚀

[engnadeau]

@Kevin-Mattheus-Moerman @davidnsousa everything looks good to me :)

@davidnsousa great job fixing the previous issues (especially adding testing)

[Kevin-Mattheus-Moerman]

@davidnsousa, reviewer @mwacaan posted these issues (albeit not in the correct repository), have you been able to work on these too?
#1019
#1020

[Kevin-Mattheus-Moerman]

@nnadeau are you able to tick the boxes at the top of this issue?

[davidnsousa]

@nnadeau thank you! :)

@Kevin-Mattheus-Moerman I am working on these issues.

@mwacaan thank you for your notes.

• I updated the paper.
• I fixed the name of the replication script.
• I do not see how do you get these errors. Everything runs fine locally and I have just updated the repository and the build passes . Are you running the most recent version of the .m files? Did you changed them? Could it be your MATLAB version? Thank you!

[davidnsousa]

@mwacaan is there anything I can do to help make the usage of the toolbox clear? Or is there anything more you can tell me about these errors? Thank you.

[Kevin-Mattheus-Moerman]

Reviewer @mwacaan has ticked all the boxes above and has e-mail myself and @davidnsousa the following (his first comment is about this issue: davidnsousa/mcsd#16):

hi David and Kevin,

the joy of backwards compatibility in matlab. thanks for adding a comment David.

I ticked all boxes assuming that this automatically finalizes my review.
good luck, best,

Matthan Caan,

Thanks @mwacaan for your review.

[Kevin-Mattheus-Moerman]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

👉 Check article proof 📄 👈

[Kevin-Mattheus-Moerman]

@davidnsousa below are some minor issues with the paper. Please work on these and regenerate the paper here by calling @whedon generate pdf.

• Typo in: ....and any measures the user may want to defined, as well as...., here defined should be define.
• Please add DOI's or hyperlinks where possible for all references.

[davidnsousa]

I was trying to tick the check boxes. The issues are fixed! Thank you!

[davidnsousa]

@Kevin-Mattheus-Moerman the version number has not changed. Here is the DOI link for the updated archive

Thank you

[arfon]

@whedon set 10.5281/zenodo.1471546 as archive

[whedon]

OK. 10.5281/zenodo.1471546 is the archive.

[arfon]

@whedon accept

[whedon]

Attempting dry run of processing paper acceptance...

[whedon]

Check final proof 👉 openjournals/joss-papers#34

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#34, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

[arfon]

@whedon accept deposit=true

[whedon]

Doing it live! Attempting automated processing of paper acceptance...

[whedon]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.00966 joss-papers#35
1. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.00966
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

[arfon]

@nnadeau, @mwacaan - many thanks for your reviews here and to @Kevin-Mattheus-Moerman for editing this submission ✨

@davidnsousa - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00966 ⚡ 🚀 💥

[whedon]

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.00966/status.svg)](https://doi.org/10.21105/joss.00966)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.00966">
  <img src="http://joss.theoj.org/papers/10.21105/joss.00966/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.00966/status.svg
   :target: https://doi.org/10.21105/joss.00966

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html
• Making a small donation to support our running costs here: https://www.flipcause.com/secure/cause_pdetails/Mjk3Nzk=

[davidnsousa]

@Kevin-Mattheus-Moerman @nnadeau @mwacaan Thank you! :)

best,

[engnadeau]

Congrats 👍

[engnadeau]

@arfon could you please submit this review to Publons? https://publons.com/a/1545968/

[arfon]

@arfon could you please submit this review to Publons? https://publons.com/a/1545968/

I'm not sure I know how to do this sorry :-\ . Any guidance/docs you might be able to point me towards here would be very welcome.

[engnadeau]

@arfon, @katyhuff introduced me to publons, maybe they have a guideline link?

[arfon]

@nnadeau - as we're not a 'partnered' journal, I think you'll need to submit this yourself: https://publons.freshdesk.com/support/solutions/articles/12000012195-how-do-i-add-reviews-to-publons-adding-reviews-

[katyhuff]

I have been adding them myself as editor of the submission (so if @nnadeau does a good job reviewing, I got to publons and note this). Since we don't send the "Thank you for your review" email that publons needs (they call it a "review receipt") I think the confirmation that a review happened comes from the editor of the submission. However, the reviewer has github notifications sent to their email, then the final thank you usually works.