Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change_notifications type (pydantic bug) #158

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Fix change_notifications type (pydantic bug) #158

merged 3 commits into from
Mar 19, 2021

Conversation

danixeee
Copy link
Contributor

Description (e.g. "Related to ...", etc.)

Closes #155.

More info is in the issue comments.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@danixeee danixeee added the bug Something isn't working label Mar 19, 2021
@danixeee danixeee requested a review from renatav March 19, 2021 12:10
@danixeee danixeee merged commit 4d8d8e2 into master Mar 19, 2021
@danixeee danixeee deleted the danixeee/pydantic-unions-fix branch March 19, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatav renatav renatav approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WorkspaceFoldersServerCapabilities.change_notifications is always sent as string
2 participants
@danixeee @renatav