Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update implementation.md with Kedro extension #457

Merged
merged 2 commits into from
May 12, 2024

Conversation

noklam
Copy link
Contributor

@noklam noklam commented May 9, 2024

Description (e.g. "Related to ...", etc.)

Added a new extension base on pygls. Thanks a lot @alcarney for guiding.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@noklam
Copy link
Contributor Author

noklam commented May 9, 2024

I see myself forgetting the commit message format again so it's likely to fail again😅 will update when I have access to computer

@alcarney alcarney merged commit 84ca723 into openlawlibrary:main May 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants