From 44669937d689690801104b5fca117586a032d034 Mon Sep 17 00:00:00 2001 From: augb Date: Thu, 21 Mar 2019 09:47:07 -0500 Subject: [PATCH 1/2] Add PR template. --- PULL_REQUEST_TEMPLATE.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 PULL_REQUEST_TEMPLATE.md diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..4e779c62 --- /dev/null +++ b/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,18 @@ +## Description (e.g. "Related to ...", etc.) + +_Please replace this description with a concise description of this Pull Request._ + +## Code review checklist (for code reviewer to complete) + +- [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR) +- [ ] Title summarizes what is changing +- [ ] Commit messages are meaningful (see [this][commit messages] for details) +- [ ] Tests have been included and/or updated, as appropriate +- [ ] Docstrings have been included and/or updated, as appropriate +- [ ] Standalone docs have been updated accordingly +- [ ] [CONTRIBUTORS.md][contributors] was updated, as appropriate +- [ ] Changelog has been updated, as needed (see [CHANGELOG.md][changelog]) + +[changelog]: https://github.com/openlawlibrary/pygls/blob/master/CHANGELOG.md +[commit messages]: https://chris.beams.io/posts/git-commit/ +[contributors]: https://github.com/openlawlibrary/pygls/blob/master/CONTRIBUTORS.md From 71c284857a1871297d50721560d58bb1f7ae6171 Mon Sep 17 00:00:00 2001 From: augb Date: Thu, 21 Mar 2019 10:11:19 -0500 Subject: [PATCH 2/2] Update changelog. --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7a894cc3..3579b856 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,10 +7,16 @@ and this project adheres to [Semantic Versioning][semver]. ## [Unreleased] +### Added + +- Add Pull Request template ([#54]) + ### Changed - Fix initialization failure when no workspace is open +[#54]: https://github.com/openlawlibrary/pygls/pull/54 + ## [0.7.3] - 01/30/2019 ### Added