Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add __repr__ and __eq__ support to Range and Location #90

Merged
merged 4 commits into from
Jan 8, 2020

Conversation

perrinjerome
Copy link
Contributor

@perrinjerome perrinjerome commented Jan 6, 2020

Description

This helps debugging and simplify testing, where we can just assert that ranges or locations are equals.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

This helps debugging and simplify testing, where we can just assert that
ranges or locations are equals.
@danixeee danixeee self-requested a review January 7, 2020 14:36
@danixeee danixeee added the enhancement New feature or request label Jan 7, 2020
@danixeee
Copy link
Contributor

danixeee commented Jan 7, 2020

@perrinjerome Great, thank you. Could you just update CHANGELOG.md and CONTRIBUTORS.md files, so I can approve / merge this one?

@perrinjerome
Copy link
Contributor Author

Thanks @danixeee ! I added commits to update changelog and contributors.

@perrinjerome
Copy link
Contributor Author

It seems build failed on AppVeyor, there's "Build execution time has reached the maximum allowed time for your plan (60 minutes).", maybe we should retry the build ? ( I cannot do this )

Copy link
Contributor

@danixeee danixeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@danixeee danixeee merged commit df8950d into openlawlibrary:master Jan 8, 2020
@danixeee danixeee mentioned this pull request Jan 8, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants