Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridLY: Some interface renamings #71

Closed
wants to merge 3 commits into from
Closed

GridLY: Some interface renamings #71

wants to merge 3 commits into from

Conversation

uliska
Copy link
Contributor

@uliska uliska commented Feb 21, 2015

Implements parts of the discussion in #64

@uliska
gridly: change/remove gridSetStructure
339134d 
\gridSetStructure is renamed to \gridSetSegmentTemplate
\gridGetStructure is removed because its purpose can be
achieved with \gridGetMusic too.
@uliska
gridly: rename gridTest to gridCompileCell
dc6b250
@Cecca
Copy link
Contributor

Cecca commented Feb 21, 2015

Thank you Urs. Can I work on this branch before merging it in gridly/development?

@uliska
Copy link
Contributor Author

uliska commented Feb 21, 2015

Ok. I won't touch it anymore.

@Cecca Cecca mentioned this pull request Feb 21, 2015
Closed
@Cecca
Copy link
Contributor

Cecca commented Feb 21, 2015

I wanted to still provide all the old functions with a deprecation warning, since I feel that public API changes should be as smooth as possible, otherwise our users would get upset.

Working on this, I got stuck on issue #72. I'm first going to fix that before continuing the work here

@Cecca
Copy link
Contributor

Cecca commented Feb 22, 2015

As you may have read on my latest commit on issue #64, I renamed a couple of functions. I ended up doing that on the gridly/development branch instead of this one because I want the change to be smoother, thus I provided deprecation warnings. (this is mainly because I have many files depending on gridly already, and I can't change them all at the same time)

@Cecca Cecca closed this Feb 23, 2015
@uliska uliska deleted the gridly/interface-1 branch February 23, 2015 09:38
@uliska uliska restored the gridly/interface-1 branch February 26, 2015 08:56
@Cecca
Copy link
Contributor

Cecca commented Feb 27, 2015

@uliska shall we delete this branch, now that gridly made its way into master? So we can keep the repo clean

@uliska
Copy link
Contributor Author

uliska commented Feb 27, 2015

Yes. I think you also have a stale branch on your fork which could be deleted. Maybe you could consider removing the fork altogether.

@uliska uliska deleted the gridly/interface-1 branch February 27, 2015 09:13
@Cecca
Copy link
Contributor

Cecca commented Feb 27, 2015

Yes, it is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cecca Cecca

Labels
enhancement GridLY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uliska @Cecca