Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridLY 0.4.0 #77

Merged
merged 2 commits into from
Feb 27, 2015
Merged

GridLY 0.4.0 #77

merged 2 commits into from
Feb 27, 2015

Conversation

Cecca
Copy link
Contributor

@Cecca Cecca commented Feb 24, 2015

Theis is release 0.4.0 of GridLY, see the changelog for details.

@Cecca Cecca assigned Cecca and uliska and unassigned Cecca Feb 24, 2015
@Cecca Cecca mentioned this pull request Feb 24, 2015
Closed
@uliska
Copy link
Contributor

uliska commented Feb 26, 2015

I will have a look at the comments in the example.ly file. I think there are some issues left in there, but I'm not completely sure. Will do that later today (hopefully)

@Cecca Cecca mentioned this pull request Feb 26, 2015
Merged
Cecca added a commit that referenced this pull request Feb 26, 2015
@Cecca
gridly: Revert "rename .automated-tests-exclude"
02fe374 
This reverts commit 2149dc9.
This is causing a merge conflict with master. These changes should wait
until PR #77 is merged
@Cecca
Copy link
Contributor Author

Cecca commented Feb 26, 2015

Now on the command line master and gridly/devel merge cleanly, I don't know why here on github the PR says that it can't merge them automatically.

Anyway, when you are OK with these changes just let me know and I'll merge manually this branch with master

@uliska
Copy link
Contributor

uliska commented Feb 26, 2015

As said I'll have to have a second look, presumsbly today.

@uliska
Copy link
Contributor

uliska commented Feb 26, 2015

As written in #84 I'm nearly fine with this. So if you don't have any issues with my PR on top of this one please merge both in turn.

@uliska uliska assigned Cecca and unassigned uliska Feb 26, 2015
Cecca and others added 2 commits February 26, 2015 18:31
@Cecca
Merge pull request #84 from openlilylib/gridly/compile-cell
2e951db 
Some edits during gridly-0.4.0 review
@Cecca
gridly: Formatting for gridCompileCell filenames
8450caa 
This commit is a follow-up of 814e195.
Now the "segment id" part of files compiled with gridCompileCell is
padded with zeroes to the length of the longest segment-id string. Thus
the cell of "soprano 4" in a grid with 100 segments, when compiled with
gridCompileCell, will produce the following pdf file

  soprano-004.pdf
@uliska
Copy link
Contributor

uliska commented Feb 26, 2015

@Cecca I checked your formatting addition and I'm fine with it. Do you wait for me to comment or is there anything else?

From my perspective you can now merge this (goes without hassles on the command line)

@Cecca Cecca merged commit 8450caa into master Feb 27, 2015
@Cecca
Copy link
Contributor Author

Cecca commented Feb 27, 2015

OK, I just merged it.

@uliska
Copy link
Contributor

uliska commented Feb 27, 2015

Great. So now I can start adding another "real world" use for GridLY :-)

Thank you for sharing your project BTW. It is encouraging to see GridLY in action so smoothly. I'm sure we can integrate it in "Das trunkne Lied", even if the complete instrumental parts have been entered with the "classical" grid approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cecca Cecca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cecca @uliska