General Plane fix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Inconsequential removal of a commented line and this is good to go. The code and resulting test file look significantly cleaner.
Thanks @eepeterson!
src/openmc_cad_adapter/surfaces.py
Outdated
| else: | ||
| cmds.append(f"intersect body {{ { ids } }} {{ { wid } }}") | ||
|
|
||
| #cmds += self.boundary_condition(ids) |
There was a problem hiding this comment.
Suggested change
| #cmds += self.boundary_condition(ids) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way general planes were created were with a number of surface manipulations and deletions which I think led to some errors in mildly complex situations. Namely some later subtraction or intersection commands would not be able to find the necessary body ID. This PR refactors the general plane half space generator to only use an intersection or subtraction with a brick sized larger than the world so there is no more explicit deletion of any body or surface IDs.