Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include puns colormaps #122

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

SteSeg
Copy link
Contributor

@SteSeg SteSeg commented Sep 12, 2023

Hi! I noticed that the plotter does not allow for perceptually uniform sequential colormaps (e.g. viridis, cividis, plasma etc.). This PR includes them.
It was sufficient to substitute:

mcolormaps.datad

with:

mcolormaps._gen_cmap_registry()

in docks.py and plotgui.py files.

Picture1

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wary of relying on a function that is intended to be private (use of leading underscore). It looks like the same thing can be achieved with:

import matplotlib.pyplot as plt

plt.colormaps()

@SteSeg
Copy link
Contributor Author

SteSeg commented Sep 13, 2023

Right, I didn't realize that. I switched to those lines now. Thanks!

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SteSeg!

@paulromano paulromano merged commit d7eb2fd into openmc-dev:develop Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants