generated from openmcp-project/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add support OCI repositories #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crets in the platform cluster
|
Ready for first review, will add more information in the README tomorrow. |
reshnm
reviewed
Oct 28, 2025
reshnm
reviewed
Oct 28, 2025
reshnm
requested changes
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM but we have to improve the image parsing logic
reshnm
previously approved these changes
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reshnm
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for OCI repositories. In general the
ProviderConfigis holding the information about available Crossplane version, OCI URLs for Helm charts and deployment images and the allowed providers (incl. package and tag).With this version, we will not longer support Helm charts from Helm repository locations.
As part of this, the PR introduces a way to sync dedicated secrets that are needed for Flux'
OCIRepositoryresource in the platform cluster and other dedicated secrets in the ManagedControlPlane cluster. The secrets that end up in the MangedControlPlane cluster are responsible for pulling the Crossplane image and potential providers.Which issue(s) this PR fixes:
Fixes #41
Special notes for your reviewer:
NONE
Release note: