From 123eb68c996604d785ab892de1707d769a7ac255 Mon Sep 17 00:00:00 2001 From: Hubert Date: Tue, 8 Jul 2025 14:46:15 +0200 Subject: [PATCH 1/3] Adding click here link to the feedback --- public/locales/en.json | 3 ++- src/components/Core/ShellBar.tsx | 15 ++++++++++++--- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/public/locales/en.json b/public/locales/en.json index f1a83b47..f8471323 100644 --- a/public/locales/en.json +++ b/public/locales/en.json @@ -104,7 +104,8 @@ "feedbackButton": "Send feedback", "feedbackButtonInfo": "Give us your feedback", "feedbackPlaceholder": "Please let us know what you think about our application", - "feedbackNotification": "*Slack notification with your email address will be shared with our Operations Team. If you have a special Feature request in mind, please create here.", + "feedbackNotificationText": "*Slack notification with your email address will be shared with our Operations Team. If you have a special Feature request in mind ", + "feedbackNotificationAction": "click here.", "feedbackThanks": "Thank you for your feedback!" }, "CreateProjectDialog": { diff --git a/src/components/Core/ShellBar.tsx b/src/components/Core/ShellBar.tsx index ce808c85..3f62bde7 100644 --- a/src/components/Core/ShellBar.tsx +++ b/src/components/Core/ShellBar.tsx @@ -31,7 +31,7 @@ import { } from 'react'; import { ShellBarProfileClickEventDetail } from '@ui5/webcomponents-fiori/dist/ShellBar.js'; import PopoverPlacement from '@ui5/webcomponents/dist/types/PopoverPlacement.js'; -import { useTranslation } from 'react-i18next'; +import { useTranslation, Trans } from 'react-i18next'; import { generateInitialsForEmail } from '../Helper/generateInitialsForEmail.ts'; import styles from './ShellBar.module.css'; import { ThemingParameters } from '@ui5/webcomponents-react-base'; @@ -151,7 +151,9 @@ export function ShellBarComponent() { > @@ -336,7 +338,14 @@ const FeedbackPopover = ({ From d73884f010dd2ac751db46dc5a54f9131cf57199 Mon Sep 17 00:00:00 2001 From: Hubert Date: Wed, 9 Jul 2025 16:52:11 +0200 Subject: [PATCH 2/3] Removing unused code --- src/components/Core/ShellBar.tsx | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/components/Core/ShellBar.tsx b/src/components/Core/ShellBar.tsx index 3f62bde7..0d4e1f3b 100644 --- a/src/components/Core/ShellBar.tsx +++ b/src/components/Core/ShellBar.tsx @@ -31,7 +31,7 @@ import { } from 'react'; import { ShellBarProfileClickEventDetail } from '@ui5/webcomponents-fiori/dist/ShellBar.js'; import PopoverPlacement from '@ui5/webcomponents/dist/types/PopoverPlacement.js'; -import { useTranslation, Trans } from 'react-i18next'; +import { useTranslation } from 'react-i18next'; import { generateInitialsForEmail } from '../Helper/generateInitialsForEmail.ts'; import styles from './ShellBar.module.css'; import { ThemingParameters } from '@ui5/webcomponents-react-base'; @@ -149,13 +149,7 @@ export function ShellBarComponent() { } onProfileClick={onProfileClick} > - + Date: Wed, 9 Jul 2025 17:00:22 +0200 Subject: [PATCH 3/3] Removing unused variable and adding proper Ui5 component --- src/components/Core/ShellBar.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/Core/ShellBar.tsx b/src/components/Core/ShellBar.tsx index 0d4e1f3b..3d19aa6e 100644 --- a/src/components/Core/ShellBar.tsx +++ b/src/components/Core/ShellBar.tsx @@ -7,6 +7,7 @@ import { FormItem, Icon, Label, + Link, List, ListItemStandard, Popover, @@ -36,7 +37,6 @@ import { generateInitialsForEmail } from '../Helper/generateInitialsForEmail.ts' import styles from './ShellBar.module.css'; import { ThemingParameters } from '@ui5/webcomponents-react-base'; import { ShellBarItemClickEventDetail } from '@ui5/webcomponents-fiori/dist/ShellBarItem.js'; -import { t } from 'i18next'; type UI5RatingIndicatorElement = HTMLElement & { value: number }; @@ -333,13 +333,13 @@ const FeedbackPopover = ({