Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Provider Vehicles Out of Beta #665

Merged
merged 7 commits into from
Sep 1, 2021
Merged

Move Provider Vehicles Out of Beta #665

merged 7 commits into from
Sep 1, 2021

Conversation

schnuerle
Copy link
Member

Explain pull request

PR to implement the discussions in #637 and move the /vehicles endpoint in Provider out of beta

Is this a breaking change

  • No, not breaking

Impacted Spec

  • provider

Additional context

N/A

@schnuerle schnuerle requested a review from a team as a code owner July 23, 2021 19:52
@schnuerle schnuerle requested a review from a team July 23, 2021 19:52
@schnuerle schnuerle self-assigned this Jul 23, 2021
@schnuerle schnuerle added the Provider Specific to the Provider API label Jul 23, 2021
@schnuerle schnuerle added this to the 1.2.0 milestone Jul 23, 2021
@schnuerle schnuerle linked an issue Jul 23, 2021 that may be closed by this pull request
Provider Vehicles - Beta 0.4.1 - Feedback #637
Closed
@schnuerle schnuerle mentioned this pull request Jul 23, 2021
Closed
@schnuerle schnuerle mentioned this pull request Aug 10, 2021
Closed
@schnuerle schnuerle linked an issue Sep 1, 2021 that may be closed by this pull request
Proposal: Clarify use cases between MDS Vehicles and GBFS #641
Closed
schnuerle
schnuerle commented Sep 1, 2021
View reviewed changes
Copy link
Member Author

@schnuerle schnuerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Out of beta.

  • Defined jurisdiction
  • updated for all vehicle states
  • Note about reconciliation with status_changes and that status_changes is source of truth
  • remove beta feature tag
  • update schema

@schnuerle schnuerle merged commit e08ffc0 into dev Sep 1, 2021
@schnuerle schnuerle deleted the ms-vehicles-beta branch September 1, 2021 15:39
@schnuerle schnuerle mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@schnuerle schnuerle

Labels
Provider Specific to the Provider API
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Proposal: Clarify use cases between MDS Vehicles and GBFS Provider Vehicles - Beta 0.4.1 - Feedback
1 participant
@schnuerle