add BitPerSampleUnit to the GUI #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BitsPerSampleUnit is missing in the GUI. It is hard-coded as Integer, because this is how it is also done in the other handlers. According to the specification of MIX, it can also be float. but this is not supported by jhove
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## integration #901 +/- ##
==============================================
Coverage 47.00% 47.00%
Complexity 1100 1100
==============================================
Files 57 57
Lines 9079 9079
Branches 1622 1622
==============================================
Hits 4268 4268
Misses 4280 4280
Partials 531 531 ☔ View full report in Codecov by Sentry. |
carlwilson
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @carlwilson
The BitsPerSampleUnit is missing in the GUI. It is hard-coded as Integer, because this is how it is also done in the other handlers. According to the specification of MIX, it can also be float. but this is not supported by jhove.
fixes #898
Sam