Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: German XML error message #958

Merged
merged 1 commit into from
Sep 3, 2024
Merged

FIX: German XML error message #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...l-hul/src/main/resources/edu/harvard/hul/ois/jhove/module/xml/ErrorMessages_de.properties
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @carlwilson , I don't understand that the XML-HUL-1 for German is different than the other languages. The SAXParseException ends with {0} and in German not. Shouldn't the {0} be there, but should be substituted by a message instead of {0}?

Sam

Copy link
Member Author

@carlwilson carlwilson Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, sorry, it was careless on my part. #960 should do the job.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I know the feeling ;-)

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
XML-HUL-1 = SAXParseException
XML-HUL-1-SUB = {0} Zeile = {1,number,integer}, Spalte = {2,number,integer}.
XML-HUL-1-SUB = Zeile = {0,number,integer}, Spalte = {1,number,integer}.
XML-HUL-2 = Maximalanzahl {0,number,integer} für Fehlermeldungen erreicht. Weitere Fehler werden nicht mehr angezeigt.
XML-HUL-3 = SAXException: {0}
XML-HUL-4 = Typ des Zeilenendes konnte nicht erkannt werden.
Expand Down
2 changes: 1 addition & 1 deletion ...l-hul/src/main/resources/edu/harvard/hul/ois/jhove/module/xml/ErrorMessages_fr.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
XML-HUL-1 = SaxParseException : {0}
XML-HUL-1-SUB = Line = {0,number,integer}, Column = {1,number,integer}.
XML-HUL-2 = {0} messages d'erreur supplémentaires non signalés
XML-HUL-2 = {0,number,integer} messages d'erreur supplémentaires non signalés
XML-HUL-3 = SaxParseException : {0}
XML-HUL-4 = Impossible de déterminer le type de fin de ligne
XML-HUL-5 = L'interface LexicalHandler n'est pas supportée par votre implémentation XML. Certaines propriétés peuvent ne pas être signalées.
Expand Down
2 changes: 1 addition & 1 deletion ...ul/src/main/resources/edu/harvard/hul/ois/jhove/module/xml/ErrorMessages_pt_BR.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
XML-HUL-1 = SaxParseException: {0}
XML-HUL-1-SUB = Line = {0,number,integer}, Column = {1,number,integer}.
XML-HUL-2 = As mensagens de erro acima de {0} não reportadas
XML-HUL-2 = As mensagens de erro acima de {0,number,integer} não reportadas
XML-HUL-3 = SaxParseException: {0}
XML-HUL-4 = Não foi possível determinar o tipo de fim de linha
XML-HUL-5 = A interface LexicalHandler não é suportada por sua implementação XML. Isso pode resultar em algumas propriedades não sendo reportadas.
Expand Down
Loading