Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Change/Delete Quarkus properties documentation #77

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

gsmet
Copy link
Collaborator

@gsmet gsmet commented Mar 16, 2024

These are some small changes to improve the documentation and make sure it is consistent with the behavior.

I also added some tests to verify the documented behavior.

gsmet added 2 commits March 16, 2024 11:58

Verified

This commit was signed with the committer’s verified signature.
neo1973 Markus Härer
@gsmet gsmet requested review from ammachado and timtebeek March 16, 2024 11:02
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix the docs!

Since you tagged two people for review I'll let you to merge when you think is best.

@gsmet
Copy link
Collaborator Author

gsmet commented Mar 18, 2024

@ammachado any chance you could have a look and check this is correct?

@gsmet gsmet merged commit e31d9bb into openrewrite:main Mar 18, 2024
2 checks passed
@gsmet
Copy link
Collaborator Author

gsmet commented Mar 19, 2024

@ammachado I used your new recipes for the first time here: quarkusio/quarkus-updates#136

And they seem to work like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants