-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase test coverage requirement to 84% #747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
madwort
commented
Sep 30, 2024
•
edited
Loading
edited
- write a few simple tests to cover more of the codebase
- ignore some uninteresting parts of the codebase
- increase the target to 84
madwort
commented
Sep 30, 2024
madwort
force-pushed
the
madwort/increase-test-coverage
branch
from
October 10, 2024 14:12
41334dc
to
b1894b8
Compare
* this allows us to easily increase pytest code coverage
* move the empty branch to the start of the function
madwort
force-pushed
the
madwort/increase-test-coverage
branch
from
October 10, 2024 14:13
b1894b8
to
09b960b
Compare
madwort
changed the title
Madwort/increase test coverage
Increase test coverage requirement to 85%
Oct 10, 2024
madwort
force-pushed
the
madwort/increase-test-coverage
branch
from
October 10, 2024 14:23
7833b93
to
8405801
Compare
madwort
changed the title
Increase test coverage requirement to 85%
Increase test coverage requirement to 84%
Oct 10, 2024
inglesp
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good little bit of incremental progress, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.