Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes to minor release process #151

Merged
merged 9 commits into from
Aug 16, 2023

Conversation

CEHENKLE
Copy link
Member

@CEHENKLE CEHENKLE commented Mar 29, 2023

Description

Updated text for proposed change to the minor release process. Please see opensearch-project/opensearch-build#150 for more context

Issues Resolved

opensearch-project/opensearch-build#150

Please do not merge this any earlier than April 14th.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@CEHENKLE CEHENKLE added discuss Issues calling for discussion bake-time Marks pull requests that are pending a minimum waiting period before they are merged labels Mar 29, 2023
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on the proposal in #150

I think this significantly duplicates the content in the release template, so I think it belongs in https://github.com/opensearch-project/opensearch-build/blob/main/.github/ISSUE_TEMPLATE/release_template.md

On release window start date:
1. We generate the first candidate with all plug-ins/components that have met the entrance criteria. If a plug-in/component hasn't met all of the criteria, we'll version bump the last released version and release that. Once the release window opens and the first candidate is generated, no additioanl features can be added, and we will not delay the start of a release window for any plug-in/component.
1. During the release window we will do final quality testing, documentation and performance testing. Bug fixes can be added in during this time, but no new features will be added.
1. We will generate a new candidate every day and post on the release issue about the status of the exit criteria. When all the exit criteria have been met, we'll announce that the candidate is ready and release it 2 days later (unless that falls on Friday, in which case we'll release on Monday)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the candidate be deployed somewhere publicly on a playground?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened an issue to request the the nightly build get deployed to playground: https://github.com/opensearch-project/opensearch-build/issues/3881

But we generally put up the RC builds, even if they're not on playground.

Feel free to add to the issue


#### Entrance criteria to start release window:
* Documentation draft PRs are up and in tech review for all component changes.
* Sanity testing is done for all components.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CEHENKLE What is sanity testing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can answer this. Sometimes we do have humans clicking some buttons and call it "sanity testing" :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. db is correct. It's very basic "please make sure everything looks sane to a human in case anything is missed by automated testing" testing.

@elfisher
Copy link
Contributor

per slack discussion should we include the proposed updates to the release calendar in this PR? Specifically moving 2.10 to 9/12, 2.11 to early November, and 2.12 to January '24

Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
dblock
dblock previously requested changes Aug 11, 2023
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update TOC?

Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
RELEASING.md Outdated

Please note: This process is for regularly scheduled minor and patch releases. For "hot" patches (patches required for security or other urgent issues) we will build, test and release as quickly as possible.

#### Entrance criteria to start release window
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This language doesn't 'flow' for me. I don't start a 'time box', I start a doing a completable task or abort when out of time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to highlight this section? If so, do you have a language suggestion?

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the right section, but I don't have a suggestion - if it works for you lets keep it. I can always make a PR if I come up with something clever

@CEHENKLE CEHENKLE dismissed dblock’s stale review August 15, 2023 19:56

addressed it

@CEHENKLE CEHENKLE removed the bake-time Marks pull requests that are pending a minimum waiting period before they are merged label Aug 15, 2023
peternied
peternied previously approved these changes Aug 15, 2023
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we lowercase the titles in the new sections?

bbarani
bbarani previously approved these changes Aug 16, 2023
Signed-off-by: CEHENKLE <henkle@amazon.com>
@CEHENKLE CEHENKLE dismissed stale reviews from bbarani and peternied via 3271d70 August 16, 2023 17:55
@CEHENKLE
Copy link
Member Author

per slack discussion should we include the proposed updates to the release calendar in this PR? Specifically moving 2.10 to 9/12, 2.11 to early November, and 2.12 to January '24

There are no dates in this PR. But I've updated the releasing.md to reflect the new dates.

@CEHENKLE
Copy link
Member Author

Any reason why we lowercase the titles in the new sections?

uppercased.

@CEHENKLE CEHENKLE merged commit 7e9f536 into opensearch-project:main Aug 16, 2023
@peternied
Copy link
Member

@CEHENKLE Did you mean to merge without waiting for the bake-time to complete?

@CEHENKLE
Copy link
Member Author

I did, since the proposal hasn't substantively changed since it went up in March. I figured that was enough baketime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues calling for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants