From 5af9a43b19c0438f647dfbbc387543d915b488a7 Mon Sep 17 00:00:00 2001 From: Josh Romero Date: Fri, 24 Feb 2023 16:01:17 -0800 Subject: [PATCH] docs(DEVELOPER_GUIDE): Make getting started comprehensive and reorganize (#3421) * docs(DEVELOPER_GUIDE): Make getting started comprehensive and reorganize Enhance getting started guide for new contributors - Add key technology breakdown with links to code guidelines - Add robust prerequisite guide - Clarify forking workflow - Explain bootstrapping - Distinguish between recommended and optional/alternative steps - Add OS-specific guidance - Add tarball usage instructions Make other developer guide improvements: - Update TOC - Remove callout linking to EUI docs - Reorder code guidelines - Standardize header capitalization and make usage guide headers imperative fixes #3396 Signed-off-by: Josh Romero Signed-off-by: Josh Romero Co-authored-by: Miki --- CHANGELOG.md | 1 + DEVELOPER_GUIDE.md | 420 ++++++++++++++++++++++++++++++--------------- 2 files changed, 283 insertions(+), 138 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9f0fcd58b885..f64b532afdff 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -124,6 +124,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - [Doc] Add readme for global query persistence ([#3001](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3001)) - Updates NOTICE file, adds validation to GitHub CI ([#3051](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3051)) - [Doc] Add current plugin persistence implementation readme ([#3081](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3081)) +- [Doc] Improve DEVELOPER_GUIDE to make first time setup quicker and easier ([#3421](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3421)) - Correct copyright date range of NOTICE file and notice generator ([#3308](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3308)) ### đź›  Maintenance diff --git a/DEVELOPER_GUIDE.md b/DEVELOPER_GUIDE.md index af3cce9f61a0..4486f8d9aec5 100644 --- a/DEVELOPER_GUIDE.md +++ b/DEVELOPER_GUIDE.md @@ -3,74 +3,198 @@ This guide applies to all development within the OpenSearch Dashboards project and is recommended for the development of all OpenSearch Dashboards plugins. -- [Getting Started](#getting-started) -- [General](#general) -- [HTML](#html) -- [API endpoints](#api-endpoints) -- [TypeScript/JavaScript](#typeScript/javaScript) -- [SASS files](#sass-files) -- [React](#react) +- [Getting started guide](#getting-started-guide) + - [Key technologies](#key-technologies) + - [Prerequisites](#prerequisites) + - [Fork and clone OpenSearch Dashboards](#fork-and-clone-opensearch-dashboards) + - [Bootstrap OpenSearch Dashboards](#bootstrap-opensearch-dashboards) + - [Run OpenSearch](#run-opensearch) + - [Run OpenSearch Dashboards](#run-opensearch-dashboards) + - [Next Steps](#next-steps) +- [Alternative development installations](#alternative-development-installations) + - [Optional - Run OpenSearch with plugins](#optional---run-opensearch-with-plugins) + - [Alternative - Run OpenSearch from tarball](#alternative---run-opensearch-from-tarball) + - [Configure OpenSearch Dashboards for security](#configure-opensearch-dashboards-for-security) +- [Building artifacts](#building-artifacts) + - [Building the Docker image](#building-the-docker-image) +- [Code guidelines](#code-guidelines) + - [General](#general) + - [HTML](#html) + - [SASS files](#sass-files) + - [TypeScript/JavaScript](#typescriptjavascript) + - [React](#react) + - [API endpoints](#api-endpoints) -Besides the content in this developer guide, the following developer guides may also apply to all development within the OpenSearch Dashboards project. Please make sure to also read them: +## Getting started guide -- [Accessibility developer guide (EUI Docs)](https://elastic.github.io/eui/#/guidelines/accessibility) -- [SASS developer guide (EUI Docs)](https://elastic.github.io/eui/#/guidelines/sass) +This guide is for any developer who wants a running local development environment where you can make, see, and test changes. It's opinionated to get you running as quickly and easily as possible, but it's not the only way to set up a development environment. -## Getting Started +If you're only interested in installing and running this project, please see the [Installing OpenSearch Dashboards](https://opensearch.org/docs/latest/install-and-configure/install-dashboards) instead. -If you would like to install and run this project, please see the [Downloads Page](https://opensearch.org/downloads.html). +If you're planning to contribute code (features or fixes) to this repository, great! Make sure to also read the [contributing guide](CONTRIBUTING.md). -#### Prerequisites +### Key technologies -We recommend using [Node Version Manager](https://github.com/nvm-sh/nvm) to install -the node version we need. +OpenSearch Dashboards is primarily a Node.js web application built using React. To effectively contribute you should be familiar with HTML ([usage guide](#html)), SASS styling ([usage guide](#sass-files)), TypeScript and JavaScript ([usage guide](#typescriptjavascript)), and React ([usage guide](#react)). + +### Prerequisites + +To develop on OpenSearch Dashboards, you'll need: + +- A [GitHub account](https://docs.github.com/en/get-started/onboarding/getting-started-with-your-github-account) +- [`git`](https://git-scm.com/) for version control +- [`Node.js`](https://nodejs.org/), [`npm`](https://www.npmjs.com/), and [`Yarn`](https://yarnpkg.com/) for building and running the project +- A code editor of your choice, configured for JavaScript/TypeScript. If you don't have a favorite editor, we suggest [Visual Studio Code](https://code.visualstudio.com/) + +If you already have these installed or have your own preferences for installing them, skip ahead to the [Fork and clone OpenSearch Dashboards](#fork-and-clone-opensearch-dashboards) section. + +#### Install `git` + +If you don't already have it installed (check with `git --version`) we recommend following the [the `git` installation guide for your OS](https://git-scm.com/downloads). + +#### Install `node` + +We recommend using [Node Version Manager (nvm)](https://github.com/nvm-sh/nvm) to install and manage different node versions, which may differ between release branches. + +1. Install nvm (as specified by the [`nvm` README](https://github.com/nvm-sh/nvm#installing-and-updating)): `curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash` +2. Install the version of the Node.js runtime defined in [`.nvmrc`](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.nvmrc): `nvm install` + +If it's the only version of node installed, it will automatically be set to the `default` alias. Otherwise, use `nvm list` to see all installed `node` versions, and `nvm use` to select the node version required by OpenSearch Dashboards. + +#### Install `yarn` + +```bash +$ npm i -g corepack +``` + +(See the [Yarn installation documentation](https://yarnpkg.com/getting-started/install) for more information.) + +### Fork and clone OpenSearch Dashboards + +All local development should be done in a [forked repository](https://docs.github.com/en/get-started/quickstart/fork-a-repo). +Fork OpenSearch Dashboards by clicking the "Fork" button at the top of the [GitHub repository](https://github.com/opensearch-project/OpenSearch-Dashboards). + +Clone your forked version of OpenSearch Dashboards to your local machine (replace `opensearch-project` in the command below with your GitHub username): + +```bash +$ git clone git@github.com:opensearch-project/OpenSearch-Dashboards.git +``` ### Bootstrap OpenSearch Dashboards -First we need to clone and bootstrap OpenSearch Dashboards: +If you haven't already, change directories to your cloned repository directory: + ```bash -$ git clone https://github.com/opensearch-project/OpenSearch-Dashboards.git $ cd OpenSearch-Dashboards -$ nvm use -$ npm i -g yarn -$ yarn osd bootstrap # This command will also install npm dependencies ``` -If you experience a network timeout while bootstrapping, you can update the timeout by configuring it in the `.yarnrc`. For example: +The `osd bootstrap` command will install the project's dependencies and build all internal packages and plugins. Bootstrapping is necessary any time you need to update packages, plugins, or dependencies, and it's recommended to run it anytime you sync with the latest upstream changes. + +```bash +$ yarn osd bootstrap +``` + +Note: If you experience a network timeout while bootstrapping, you can update the timeout by configuring it in the [`.yarnrc`](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.yarnrc). For example: + ``` network-timeout 1000000 ``` -### Configure OpenSearch Dashboards +If you've previously bootstrapped the project and need to start fresh, first run: -*This step is only mandatory if you have https/authentication enabled, or if you use the OpenSearch Docker image in its default configuration.* +```bash +$ yarn osd clean +``` -Once the bootstrap of OpenSearch Dashboards is finished, you need to apply some -changes to `opensearch_dashboards.yml` in order to connect to OpenSearch. +### Run OpenSearch -```yml -opensearch.hosts: ["https://localhost:9200"] -opensearch.username: "admin" # Default username on the docker image -opensearch.password: "admin" # Default password on the docker image -opensearch.ssl.verificationMode: none +OpenSearch Dashboards requires a running version of OpenSearch to connect to. In a separate terminal you can run the latest snapshot built using: + +_(Linux and Windows only - for MacOS, you'll need to [run OpenSearch from a tarball](#alternative---run-opensearch-from-tarball) instead)_ +```bash +$ yarn opensearch snapshot ``` -### Run OpenSearch +### Run OpenSearch Dashboards + +_**Warning:** Starting the OpenSearch Dashboards instance before the OpenSearch server is fully initialized can cause Dashboards to misbehave. Ensure that the OpenSearch server instance is up and running first. You can validate by running `curl localhost:9200` in another console tab or window (see [OpenSearch developer guide](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#run-opensearch))._ -You need to have an OpenSearch server up and running to be able to run OpenSearch -Dashboards. In a separate terminal you can run the latest snapshot built using: +Start the OpenSearch Dashboards development server: ```bash -$ yarn opensearch snapshot +$ yarn start ``` -If you would like to download a specific OpenSearch plugin on the cluster snapshot, pass the `--P` flag after `yarn opensearch snapshot`. We can use the flag multiple times to install multiple plugins on the cluster snapshot. The argument value can be URL to the plugin's zip file, maven coordinates of the plugin or for local zip files, use `file:` followed by the absolute or relative path to the plugin zip file. Below is the example help command: +When the server is up and ready (the console messages will look something like this), + +``` +[info][listening] Server running at http://localhost:5603/pgt +[info][server][OpenSearchDashboards][http] http server running at http://localhost:5603/pgt +``` + +click on the link displayed in your terminal to +access it. + +Note - it may take a couple minutes to generate all the necessary bundles. If the Dashboards link is not yet accessible, wait for a log message like ``` +[success][@osd/optimizer] 28 bundles compiled successfully after 145.9 sec, watching for changes +``` + +### Next Steps + +Now that you have a development environment to play with, there are a number of different paths you may take next. + +#### Learn about the OpenSearch Dashboards architecture and plugins + +- [Introduction to OpenSearch Dashboards Plugins](https://opensearch.org/blog/dashboards-plugins-intro/) blog post +- [OpenSearch Dashboards plugin user documentation](https://opensearch.org/docs/latest/install-and-configure/install-dashboards/plugins/) (install, update, and remove) +- Much of the technical architectural information about the plugin system is located in `/src/core` + - [README](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/README.md) + - [Plugin principles](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/PRINCIPLES.md) + - [Plugin conventions](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/CONVENTIONS.md#technical-conventions) + - [Plugin testing](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/TESTING.md) + +#### Review user tutorials to understand the key features and workflows + +- The [Quickstart guide for OpenSearch Dashboards](https://opensearch.org/docs/latest/dashboards/quickstart-dashboards/) will show you how to explore, inspect, and visualize sample data +- [Running queries in the Dev Tools Console](https://opensearch.org/docs/latest/dashboards/run-queries/) provides helpful guidance on how to interact with OpenSearch + +#### Explore essential plugins and APIs + +The easiest way to understand some of the essential plugins and APIs is to run OpenSearch Dashboards with [developer examples](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/examples/) turned on: + +```bash +$ yarn start --run-examples +``` + +#### Review code guidelines and conventions + +- [Project code guidelines](#code-guidelines) +- [Project testing guidelines](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/TESTING.md) +- [Plugin conventions](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/CONVENTIONS.md#technical-conventions) + +## Alternative development installations + +Although the [getting started guide](#getting-started-guide) covers the recommended development environment setup, there are several alternatives worth being aware of. + +### Optional - Run OpenSearch with plugins + +By default, the snapshot command will run [a minimal distribution of OpenSearch](https://opensearch.org/downloads.html#minimal), with no plugins installed. + +If you would like to run OpenSearch with a particular plugin installed on the cluster snapshot, pass the `--P` flag after `yarn opensearch snapshot`. You can use the flag multiple times to install multiple plugins. The argument value can be a URL to the plugin's zip file, maven coordinates of the plugin, or a local zip file path (use `file://` followed by the absolute or relative path, in that case). For example: + +_(Linux and Windows only - for MacOS, you'll need to [run OpenSearch from a tarball](#alternative---run-opensearch-from-tarball) instead)_ +```bash $ yarn opensearch snapshot --P https://repo1.maven.org/maven2/org/opensearch/plugin/opensearch-test-plugin/2.4.0.0/opensearch-test-plugin-2.4.0.0.zip ``` -Following are the list of options that can be passed after `yarn opensearch snapshot` to configure the cluster snapshot. +Note - if you add the [`security` plugin](https://github.com/opensearch-project/security), you'll also need to [configure OpenSearch Dashboards for security](#configure-opensearch-dashboards-for-security). + +#### Other snapshot configuration options + +Additional options can be passed after `yarn opensearch snapshot` to further configure the cluster snapshot. + Options: --license Run with a 'oss', 'basic', or 'trial' license [default: oss] @@ -82,26 +206,42 @@ Options: -E Additional key=value settings to pass to OpenSearch --download-only Download the snapshot but don't actually start it --ssl Sets up SSL on OpenSearch - --P OpenSearch plugin artifact URL to install it on the cluster. + --P OpenSearch plugin artifact URL to install it on the cluster. -``` +```bash $ yarn opensearch snapshot --version 2.2.0 -E cluster.name=test -E path.data=/tmp/opensearch-data --P org.opensearch.plugin:test-plugin:2.2.0.0 --P file:/home/user/opensearch-test-plugin-2.2.0.0.zip ``` -**Warning:** Starting the Dashboards instance before or during the initialization of the OpenSearch Server can cause Dashboards to sometimes misbehave. Ensure that the OpenSearch server instance is up and running first before starting up the Dashboards dev server from the next step. +### Alternative - Run OpenSearch from tarball -### Run OpenSearch Dashboards +OpenSearch does not yet create artifacts for MacOS, so you'll need to download, install, and run the tarball instead. (You'll also need Java installed and the `JAVA_HOME` environmental variable set - see [OpenSearch developer guide](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#install-prerequisites) for details). -After you've installed OpenSearch Dashboards and configured it, you can start -the development server: -```bash -$ yarn start +1. Download the latest minimal distribution of OpenSearch from [the downloads page](https://opensearch.org/downloads.html#minimal). Note the version and replace in commands below. +2. Unzip the `tar.gz` file: `tar -xvf opensearch--linux-x64.tar.gz` +3. Change directory: `cd opensearch-` +4. Run the cluster: `./bin/opensearch` + +Note - OpenSearch and OpenSearch Dashboards must have matching version strings. Because the tarball is the latest _released_ version of OpenSearch, it's likely behind the version on the `main` branch of OpenSearch Dashboards, which is generally set to the next upcoming major release. So to work from main, update [the OpenSearch Dashboards version in `package.json`](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/package.json#L14) to match the OpenSearch version running. + +This method can also be used to develop against the [full distribution of OpenSearch](https://opensearch.org/downloads.html#opensearch) instead. In that case, you'll also need to [configure OpenSearch Dashboards for security](#configure-opensearch-dashboards-for-security). + +### Configure OpenSearch Dashboards for security + +*This step is only mandatory if you have the [`security` plugin](https://github.com/opensearch-project/security) installed on your OpenSearch cluster with https/authentication enabled.* + +Once the bootstrap of OpenSearch Dashboards is finished, you need to apply some +changes to the default [`opensearch_dashboards.yml`](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/config/opensearch_dashboards.yml#L25-L72) in order to connect to OpenSearch. + +```yml +opensearch.hosts: ["https://localhost:9200"] +opensearch.username: "admin" # Default username on the docker image +opensearch.password: "admin" # Default password on the docker image +opensearch.ssl.verificationMode: none ``` -When the server is up and ready, click on the link displayed in your terminal to -access it. +For more detailed documentation, see [Configure TLS for OpenSearch Dashboards](https://opensearch.org/docs/latest/install-and-configure/install-dashboards/tls). -### Building the artifacts +## Building artifacts To build the artifacts for all supported platforms, run the following: @@ -115,12 +255,13 @@ If you want to build a specific platform, pass the platform flag after `yarn bui yarn build-platform --darwin ``` -You could pass one or multiple flags. If you don't pass any flag, `yarn build-platform` will build an artifact based on your local environment. +You could pass one or multiple flags. If you don't pass any flag, `yarn build-platform` will build an artifact based on your local environment. Currently, the supported flags for this script are: * `darwin` (builds Darwin x64) * `linux` (builds Linux x64) -* `linux-arm` (builds Linux ARM64). +* `linux-arm` (builds Linux ARM64). +* `windows` (builds Windows x64) If you would like to build only a DEB x64 artifact, run the following: @@ -146,7 +287,7 @@ If you would like to build only a RPM ARM64 artifact, run the following: yarn build --rpm-arm --skip-archives ``` -### Building the Docker Image +### Building the Docker image To build the Docker image, run the following: @@ -155,9 +296,11 @@ yarn osd bootstrap yarn build --docker ``` -## General +## Code guidelines -### Filenames +### General + +#### Filenames All filenames should use `snake_case`. @@ -165,12 +308,12 @@ All filenames should use `snake_case`. **Wrong:** `src/opensearch-dashboards/IndexPatterns/IndexPattern.js` -### Do not comment out code +#### Do not comment out code We use a version management system. If a line of code is no longer needed, remove it, don't simply comment it out. -### Prettier and Linting +#### Prettier and linting We are gradually moving the OpenSearch Dashboards code base over to Prettier. All TypeScript code and some JavaScript code (check `.eslintrc.js`) is using Prettier to format code. You @@ -182,11 +325,11 @@ Consider every linting rule and every Prettier rule to be also part of our devel and disable them only in exceptional cases and ideally leave a comment why they are disabled at that specific place. -## HTML +### HTML This part contains developer guide rules around general (framework agnostic) HTML usage. -### Camel case `id` and `data-test-subj` +#### Camel case `id` and `data-test-subj` Use camel case for the values of attributes such as `id` and `data-test-subj` selectors. @@ -210,14 +353,14 @@ buttons.map(btn => ( ) ``` -### Capitalization in HTML and CSS should always match +#### Capitalization in HTML and CSS should always match It's important that when you write CSS/SASS selectors using classes, IDs, and attributes (keeping in mind that we should _never_ use IDs and attributes in our selectors), that the capitalization in the CSS matches that used in the HTML. HTML and CSS follow different case sensitivity rules, and we can avoid subtle gotchas by ensuring we use the same capitalization in both of them. -### How to generate ids? +#### How to generate ids? When labeling elements (and for some other accessibility tasks) you will often need ids. Ids must be unique within the page i.e. no duplicate ids in the rendered DOM @@ -270,45 +413,50 @@ id generator. You can also use this service outside of React. -## API endpoints +### SASS files -The following developer guide rules are targeting development of server side API endpoints. +When writing a new component, create a sibling SASS file of the same name and import directly into the **top** of the JS/TS component file. Doing so ensures the styles are never separated or lost on import and allows for better modularization (smaller individual plugin asset footprint). -### Paths +All SASS (.scss) files will automatically build with the [EUI](https://elastic.github.io/eui/#/guidelines/sass) & OpenSearch Dashboards invisibles (SASS variables, mixins, functions) from the [`globals_[theme].scss` file](src/core/public/core_app/styles/_globals_v7light.scss). -API routes must start with the `/api/` path segment, and should be followed by the plugin id if applicable: +While the styles for this component will only be loaded if the component exists on the page, +the styles **will** be global and so it is recommended to use a three letter prefix on your +classes to ensure proper scope. -**Right:** `/api/marvel/nodes` +**Example:** -**Wrong:** `/marvel/api/nodes` +```tsx +// component.tsx -### snake_case +import './component.scss'; +// All other imports below the SASS import -OpenSearch Dashboards uses `snake_case` for the entire API, just like OpenSearch. All urls, paths, query string parameters, values, and bodies should be `snake_case` formatted. +export const Component = () => { + return ( +
+ ); +} +``` -_Right:_ +```scss +// component.scss -``` -POST /api/opensearch-dashboards/index_patterns -{ - "id": "...", - "time_field_name": "...", - "fields": [ - ... - ] -} +.plgComponent { ... } ``` -## TypeScript/JavaScript +Do not use the underscore `_` SASS file naming pattern when importing directly into a javascript file. + + +### TypeScript/JavaScript The following developer guide rules apply for working with TypeScript/JavaScript files. -### TypeScript vs. JavaScript +#### TypeScript vs. JavaScript Whenever possible, write code in TypeScript instead of JavaScript, especially if it's new code. Check out [TYPESCRIPT.md](TYPESCRIPT.md) for help with this process. -### Prefer modern JavaScript/TypeScript syntax +#### Prefer modern JavaScript/TypeScript syntax You should prefer modern language features in a lot of cases, e.g.: @@ -319,7 +467,7 @@ You should prefer modern language features in a lot of cases, e.g.: - Prefer the spread operator for copying arrays (`[...arr]`) over `arr.slice()` - Use optional chaining (`?.`) and nullish Coalescing (`??`) over `lodash.get` (and similar utilities) -### Avoid mutability and state +#### Avoid mutability and state Wherever possible, do not rely on mutable state. This means you should not reassign variables, modify object properties, or push values to arrays. @@ -339,7 +487,7 @@ function addBar(foos, foo) { } ``` -### Avoid `any` whenever possible +#### Avoid `any` whenever possible Since TypeScript 3.0 and the introduction of the [`unknown` type](https://mariusschulz.com/blog/the-unknown-type-in-typescript) there are rarely any @@ -353,7 +501,7 @@ If you’re not having `any` in your plugin or are starting a new plugin, you sh [`@typescript-eslint/no-explicit-any`](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-explicit-any.md) linting rule for your plugin via the [`.eslintrc.js`](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/.eslintrc.js) config. -### Avoid non-null assertions +#### Avoid non-null assertions You should try avoiding non-null assertions (`!.`) wherever possible. By using them you tell TypeScript, that something is not null even though by it’s type it could be. Usage of non-null @@ -365,14 +513,14 @@ or using [user defined type guards](https://www.typescriptlang.org/docs/handbook to properly tell TypeScript what type a variable has. Using non-null assertion increases the risk for future bugs. In case the condition under which we assumed that the -variable can’t be null has changed (potentially even due to changes in compeltely different files), the non-null +variable can’t be null has changed (potentially even due to changes in completely different files), the non-null assertion would now wrongly disable proper type checking for us. If you’re not using non-null assertions in your plugin or are starting a new plugin, consider enabling the [`@typescript-eslint/no-non-null-assertion`](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-non-null-assertion.md) linting rule for you plugin in the [`.eslintrc.js`](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.eslintrc.js) config. -### Return/throw early from functions +#### Return/throw early from functions To avoid deep nesting of if-statements, always return a function's value as early as possible. And where possible, do any assertions first: @@ -405,7 +553,7 @@ function doStuff(val) { } ``` -### Use object destructuring +#### Use object destructuring This helps avoid temporary references and helps prevent typo-related bugs. @@ -429,7 +577,7 @@ function fullName(user) { } ``` -### Use array destructuring +#### Use array destructuring Directly accessing array values via index should be avoided, but if it is necessary, use array destructuring: @@ -445,7 +593,7 @@ const first = arr[0]; const second = arr[1]; ``` -### Magic numbers/strings +#### Avoid magic numbers/strings These are numbers (or other values) simply used in line in your code. _Do not use these_, give them a variable name so they can be understood and changed @@ -465,7 +613,7 @@ if (width < 300) { } ``` -### Modules +#### Use native ES2015 module syntax Module dependencies should be written using native ES2015 syntax wherever possible (which is almost everywhere): @@ -491,7 +639,7 @@ file that does not pass run through webpack, then use CommonJS modules. In those even rarer cases where you're writing client-side code that does not run through webpack, then do not use a module loader at all. -#### Import only top-level modules +##### Import only top-level modules The files inside a module are implementation details of that module. They should never be imported directly. Instead, you must only import the top-level @@ -517,12 +665,12 @@ import inFoo from 'foo/child'; import inSibling from '../foo/child'; ``` -### Global definitions +#### Avoid global definitions Don't do this. Everything should be wrapped in a module that can be depended on by other modules. Even things as simple as a single value should be a module. -### Only use ternary operators for small, simple code +#### Use ternary operators only for small, simple code And _never_ use multiple ternaries together, because they make it more difficult to reason about how different values flow through the conditions @@ -536,7 +684,7 @@ const foo = a === b ? 1 : 2; const foo = a === b ? 1 : a === c ? 2 : 3; ``` -### Use descriptive conditions +#### Use descriptive conditions Any non-trivial conditions should be converted to functions or assigned to descriptively named variables. By breaking up logic into smaller, @@ -569,7 +717,7 @@ if (thing instanceof Shape && !(thing instanceof Square)) { } ``` -### Name regular expressions +#### Name regular expressions ```js // good @@ -585,13 +733,13 @@ if (password.length >= 4 && /^(?=.*\d).{4,}$/.test(password)) { } ``` -### Write small functions +#### Write small functions Keep your functions short. A good function fits on a slide that the people in the last row of a big room can comfortably read. So don't count on them having perfect vision and limit yourself to ~15 lines of code per function. -### Use "rest" syntax rather than built-in `arguments` +#### Use "rest" syntax rather than built-in `arguments` For expressiveness sake, and so you can be mix dynamic and explicit arguments. @@ -608,7 +756,7 @@ function something(foo) { } ``` -### Default argument syntax +#### Use default argument syntax Always use the default argument syntax for optional arguments. @@ -641,7 +789,7 @@ function foo(options = {}, bar) { } ``` -### Use thunks to create closures, where possible +#### Use thunks to create closures, where possible For trivial examples (like the one that follows), thunks will seem like overkill, but they encourage isolating the implementation details of a closure @@ -667,7 +815,7 @@ setTimeout(() => { }, 1000); ``` -### Use slashes for comments +#### Use slashes for comments Use slashes for both single line and multi line comments. Try to write comments that explain higher level mechanisms or clarify difficult @@ -719,7 +867,7 @@ if (isSessionValid) { } ``` -### Getters and Setters +#### Use getters but not setters Feel free to use getters that are free from [side effects][sideeffect], like providing a length property for a collection class. @@ -728,44 +876,18 @@ Do not use setters, they cause more problems than they can solve. [sideeffect]: http://en.wikipedia.org/wiki/Side_effect_(computer_science) -## SASS files - -When writing a new component, create a sibling SASS file of the same name and import directly into the **top** of the JS/TS component file. Doing so ensures the styles are never separated or lost on import and allows for better modularization (smaller individual plugin asset footprint). - -All SASS (.scss) files will automatically build with the [EUI](https://elastic.github.io/eui/#/guidelines/sass) & OpenSearch Dashboards invisibles (SASS variables, mixins, functions) from the [`globals_[theme].scss` file](src/core/public/core_app/styles/_globals_v7light.scss). - -While the styles for this component will only be loaded if the component exists on the page, -the styles **will** be global and so it is recommended to use a three letter prefix on your -classes to ensure proper scope. - -**Example:** - -```tsx -// component.tsx +#### Attribution -import './component.scss'; -// All other imports below the SASS import - -export const Component = () => { - return ( -
- ); -} -``` - -```scss -// component.scss - -.plgComponent { ... } -``` - -Do not use the underscore `_` SASS file naming pattern when importing directly into a javascript file. +Parts of the JavaScript developer guide were initially forked from the +[node style guide](https://github.com/felixge/node-style-guide) created by [Felix Geisendörfer](http://felixge.de/) which is +licensed under the [CC BY-SA 3.0](http://creativecommons.org/licenses/by-sa/3.0/) +license. -## React +### React The following developer guide rules are specific for working with the React framework. -### Prefer reactDirective over react-component +#### Prefer reactDirective over react-component When using `ngReact` to embed your react components inside Angular HTML, prefer the `reactDirective` service over the `react-component` directive. @@ -789,7 +911,7 @@ Using `react-component` means adding a bunch of components into angular, while ` ``` -### Action function names and prop function names +#### Name action functions and prop functions appropriately Name action functions in the form of a strong verb and passed properties in the form of on. E.g: @@ -798,9 +920,31 @@ Name action functions in the form of a strong verb and passed properties in the ``` -## Attribution +### API endpoints -Parts of the JavaScript developer guide were initially forked from the -[node style guide](https://github.com/felixge/node-style-guide) created by [Felix Geisendörfer](http://felixge.de/) which is -licensed under the [CC BY-SA 3.0](http://creativecommons.org/licenses/by-sa/3.0/) -license. +The following developer guide rules are targeting development of server side API endpoints. + +#### Use only `/api/` as base path + +API routes must start with the `/api/` path segment, and should be followed by the plugin id if applicable: + +**Right:** `/api/marvel/nodes` + +**Wrong:** `/marvel/api/nodes` + +#### Use snake_case + +OpenSearch Dashboards uses `snake_case` for the entire API, just like OpenSearch. All urls, paths, query string parameters, values, and bodies should be `snake_case` formatted. + +_Right:_ + +``` +POST /api/opensearch-dashboards/index_patterns +{ + "id": "...", + "time_field_name": "...", + "fields": [ + ... + ] +} +```