Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of non-inclusive term "whitelist" with neutral language #533

Closed
mrudrego opened this issue Jun 23, 2021 · 3 comments
Closed

Removal of non-inclusive term "whitelist" with neutral language #533

mrudrego opened this issue Jun 23, 2021 · 3 comments
Labels
enhancement New feature or request v3.0.0

Comments

@mrudrego
Copy link

mrudrego commented Jun 23, 2021

Is your feature request related to a problem? Please describe.

OpenSearch-Dashboards(Kibana) has a configuration property elasticsearch.requestHeadersWhitelist.
There are concerns raised on usage of this non-inclusive terminology. Linux team has approved on replacing these non-inclusive terminologies. There are many other tech companies and open-source projects that have removed references to racially-charged jargon from their code for more neutral and inclusive language.

Describe the solution you'd like

This request is to replace the term Whitelist used in one of the OpenSearch-Dashboards(kibana) configuration with a neutral word say allowlist or passlist

Additional context

Reference: https://www.zdnet.com/article/linux-team-approves-new-terminology-bans-terms-like-blacklist-and-slave/

@mrudrego mrudrego added the enhancement New feature or request label Jun 23, 2021
@dblock
Copy link
Member

dblock commented Jun 23, 2021

Thanks for highlighting this. A similar issue was discussed in opensearch-project/OpenSearch#472, specifically opensearch-project/OpenSearch#472 (comment). We want to fix this, please do consider contributing a backwards-compatible change.

@tmarkley tmarkley added the v1.2.0 label Sep 1, 2021
@kavilla
Copy link
Member

kavilla commented Sep 1, 2021

For code, it should be straight forward. But configs, I recommend we initially start with update name and deprecating the previous config key instead of out right removing them. If we end up removing them then the application won't start if the user does not modify their config which would go against our backwards-compatible change. But for 2.x we can remove them completely.

@kavilla
Copy link
Member

kavilla commented Apr 5, 2022

Hello we will track this here: #1319. We will work on deprecating this configurations then for 3.x we will remove them as this will be a breaking change.

@kavilla kavilla added v3.0.0 and removed v2.0.0 labels Apr 5, 2022
@kavilla kavilla closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3.0.0
Projects
None yet
Development

No branches or pull requests

4 participants