From 59d97652732371db7430d2e798c919b514a44315 Mon Sep 17 00:00:00 2001 From: Finn Carroll Date: Thu, 22 Aug 2024 20:40:33 -0700 Subject: [PATCH] Comment Signed-off-by: Finn Carroll --- .../search/fetch/serde/FetchSearchResultsSerDe.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/server/src/main/java/org/opensearch/search/fetch/serde/FetchSearchResultsSerDe.java b/server/src/main/java/org/opensearch/search/fetch/serde/FetchSearchResultsSerDe.java index d56d706261627..b418a798112c9 100644 --- a/server/src/main/java/org/opensearch/search/fetch/serde/FetchSearchResultsSerDe.java +++ b/server/src/main/java/org/opensearch/search/fetch/serde/FetchSearchResultsSerDe.java @@ -21,15 +21,10 @@ */ public class FetchSearchResultsSerDe implements SerDe.StreamSerializer, SerDe.StreamDeserializer { /** - * TODO NOTE: FetchSearchResult inheritance structure is as follows. + * NOTE: FetchSearchResultSerDe should mirror class inheritence strucutre. * TransportMessage -> TransportResponse -> SearchPhaseResult -> FetchSearchResult. - * Serialization of parent classes is currently a no-op. - * For completeness these parent classes should be mirrored here respectively with: - * TransportMessageSerDe, TransportResponseSerDe, SearchPhaseResultSerDe. - * However, currently only SearchHitsSerDe is needed for serialization. * - * This is implicitely enforced by FetchSearchResult as well on the serialization side. - * writeTo doesn't call a parent implementation... + * Serialization of parent classes is currently a no-op so leaving as is for now. */ SearchHitsSerDe searchHitsSerDe;