fixed PR comments

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

Author: vinaykpud

server/src/main/java/org/opensearch/cluster/node/DiscoveryNode.java

@@ -77,7 +77,7 @@ public class DiscoveryNode implements VerifiableWriteable, ToXContentFragment {
 
     static final String COORDINATING_ONLY = "coordinating_only";
 
-    static final String SEARCH_ONLY = "searchonly";
+    static final String SEARCH_ONLY = "search_only";
 
     public static boolean nodeRequiresLocalStorage(Settings settings) {
         boolean localStorageEnable = Node.NODE_LOCAL_STORAGE_SETTING.get(settings);

server/src/main/java/org/opensearch/cluster/routing/allocation/decider/SearchReplicaAllocationDecider.java

@@ -35,14 +35,18 @@ public Decision canRemain(ShardRouting shardRouting, RoutingNode node, RoutingAl
     private Decision canAllocate(ShardRouting shardRouting, DiscoveryNode node, RoutingAllocation allocation) {
         boolean isSearchReplica = shardRouting.isSearchOnly();
 
-        if (node.isSearchDedicatedDataNode() && isSearchReplica) {
-            return allocation.decision(Decision.YES, NAME, "node is search dedicated data node and shard is search replica");
-        } else if (!node.isSearchDedicatedDataNode() && !isSearchReplica) {
-            return allocation.decision(Decision.YES, NAME, "node is not search dedicated data node and shard is replica");
-        } else if (node.isSearchDedicatedDataNode() && !isSearchReplica) {
-            return allocation.decision(Decision.NO, NAME, "Node is a search dedicated data node but shard is not a search replica");
+        if (node.isSearchDedicatedDataNode()) {
+            if (isSearchReplica) {
+                return allocation.decision(Decision.YES, NAME, "node is search dedicated data node and shard is search replica");
+            } else {
+                return allocation.decision(Decision.NO, NAME, "Node is a search dedicated data node but shard is not a search replica");
+            }
         } else {
-            return allocation.decision(Decision.NO, NAME, "Node is not a search dedicated data node but shard is a search replica");
+            if (isSearchReplica) {
+                return allocation.decision(Decision.NO, NAME, "Node is not a search dedicated data node but shard is a search replica");
+            } else {
+                return allocation.decision(Decision.YES, NAME, "node is not search dedicated data node and shard is not a search replica");
+            }
         }
     }
 }