From ab54956a4d9bc00e91ef5f1949409c0b34e626f9 Mon Sep 17 00:00:00 2001 From: Suraj Singh Date: Tue, 11 Apr 2023 17:27:16 -0700 Subject: [PATCH] More cleanup Signed-off-by: Suraj Singh --- .../src/main/java/org/opensearch/index/store/Store.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/server/src/main/java/org/opensearch/index/store/Store.java b/server/src/main/java/org/opensearch/index/store/Store.java index 9de8084c0f8c4..016d42df71efc 100644 --- a/server/src/main/java/org/opensearch/index/store/Store.java +++ b/server/src/main/java/org/opensearch/index/store/Store.java @@ -814,13 +814,11 @@ private void cleanupFiles(String reason) * This method is used to clean up un referenced files by reader manager. * @throws IOException when there is an IO error in clean up. */ - private void cleanUnReferencedReaderManagerFiles() throws IOException { + private void cleanUnReferencedFiles() throws IOException { assert indexSettings.isSegRepEnabled(); - // fetch a snapshot from the latest on disk Segments_N file. This can be behind - // the passed in local in memory snapshot, so we want to ensure files it references are not removed. metadataLock.writeLock().lock(); try (Lock writeLock = directory.obtainLock(IndexWriter.WRITE_LOCK_NAME)) { - cleanupFiles("After commit"); + cleanupFiles("Segrep cleanup after commit"); } finally { metadataLock.writeLock().unlock(); } @@ -1916,7 +1914,7 @@ public void decRefFileDeleter(Collection files) { if (this.indexSettings.isSegRepEnabled()) { this.replicaFileTracker.decRef(files); try { - cleanUnReferencedReaderManagerFiles(); + cleanUnReferencedFiles(); } catch (IOException e) { logger.error("Error cleaning files", e); }