Modified DeleteSnapshotV2IT for Warm Index

Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>

Author: Gagan Singh Saini

server/src/internalClusterTest/java/org/opensearch/snapshots/DeleteSnapshotV2IT.java

@@ -8,14 +8,21 @@
 
 package org.opensearch.snapshots;
 
+import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
+import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
+
+import org.apache.lucene.tests.util.LuceneTestCase;
 import org.opensearch.action.admin.cluster.snapshots.create.CreateSnapshotResponse;
 import org.opensearch.action.support.clustermanager.AcknowledgedResponse;
 import org.opensearch.cluster.metadata.IndexMetadata;
 import org.opensearch.common.settings.Settings;
 import org.opensearch.common.unit.TimeValue;
 import org.opensearch.core.common.unit.ByteSizeUnit;
+import org.opensearch.core.common.unit.ByteSizeValue;
 import org.opensearch.index.remote.RemoteStoreEnums;
+import org.opensearch.index.store.remote.file.CleanerDaemonThreadLeakFilter;
 import org.opensearch.indices.RemoteStoreSettings;
+import org.opensearch.node.Node;
 import org.opensearch.node.remotestore.RemoteStorePinnedTimestampService;
 import org.opensearch.remotestore.RemoteStoreBaseIntegTestCase;
 import org.opensearch.repositories.blobstore.BlobStoreRepository;
@@ -26,18 +33,55 @@
 import java.nio.file.Files;
 import java.nio.file.NoSuchFileException;
 import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.Collection;
 import java.util.List;
 import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
 
+import static org.opensearch.cluster.routing.UnassignedInfo.INDEX_DELAYED_NODE_LEFT_TIMEOUT_SETTING;
+import static org.opensearch.common.util.FeatureFlags.WRITABLE_WARM_INDEX_SETTING;
 import static org.opensearch.index.IndexSettings.INDEX_REMOTE_TRANSLOG_KEEP_EXTRA_GEN_SETTING;
 import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertAcked;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.greaterThan;
 
+// TODO : Delete Index in teardown and prune cache to remove Index Files
+@LuceneTestCase.SuppressFileSystems("*")
+@ThreadLeakFilters(filters = CleanerDaemonThreadLeakFilter.class)
 @OpenSearchIntegTestCase.ClusterScope(scope = OpenSearchIntegTestCase.Scope.TEST, numDataNodes = 0)
 public class DeleteSnapshotV2IT extends AbstractSnapshotIntegTestCase {
 
+    public DeleteSnapshotV2IT(Settings nodeSettings) {
+        super(nodeSettings);
+    }
+
+    /*
+    Disabling MockFSIndexStore plugin as the MockFSDirectoryFactory wraps the FSDirectory over a OpenSearchMockDirectoryWrapper which extends FilterDirectory (whereas FSDirectory extends BaseDirectory)
+    As a result of this wrapping the local directory of Composite Directory does not satisfy the assertion that local directory must be of type FSDirectory
+    */
+    @Override
+    protected boolean addMockIndexStorePlugin() {
+        return !WRITABLE_WARM_INDEX_SETTING.get(settings);
+    }
+
+    @ParametersFactory
+    public static Collection<Object[]> parameters() {
+        return Arrays.asList(
+            new Object[] { Settings.builder().put(WRITABLE_WARM_INDEX_SETTING.getKey(), false).build() },
+            new Object[] { Settings.builder().put(WRITABLE_WARM_INDEX_SETTING.getKey(), true).build() }
+        );
+    }
+
+    @Override
+    protected Settings nodeSettings(int nodeOrdinal) {
+        ByteSizeValue cacheSize = new ByteSizeValue(16, ByteSizeUnit.GB);
+        return Settings.builder()
+            .put(super.nodeSettings(nodeOrdinal))
+            .put(Node.NODE_SEARCH_CACHE_SIZE_SETTING.getKey(), cacheSize.toString())
+            .build();
+    }
+
     private static final String REMOTE_REPO_NAME = "remote-store-repo-name";
 
     private void keepPinnedTimestampSchedulerUpdated() throws InterruptedException {
@@ -55,8 +99,8 @@ public void testDeleteShallowCopyV2() throws Exception {
         final Path remoteStoreRepoPath = randomRepoPath();
         internalCluster().startClusterManagerOnlyNode(snapshotV2Settings(remoteStoreRepoPath));
 
-        internalCluster().startDataOnlyNode(snapshotV2Settings(remoteStoreRepoPath));
-        internalCluster().startDataOnlyNode(snapshotV2Settings(remoteStoreRepoPath));
+        internalCluster().startDataAndWarmNodes(1, snapshotV2Settings(remoteStoreRepoPath));
+        internalCluster().startDataAndWarmNodes(1, snapshotV2Settings(remoteStoreRepoPath));
 
         String indexName1 = "testindex1";
         String indexName2 = "testindex2";
@@ -139,7 +183,7 @@ public void testRemoteStoreCleanupForDeletedIndexForSnapshotV2() throws Exceptio
             .put(RemoteStoreSettings.CLUSTER_REMOTE_STORE_PATH_TYPE_SETTING.getKey(), RemoteStoreEnums.PathType.FIXED.toString())
             .build();
         String clusterManagerName = internalCluster().startClusterManagerOnlyNode(settings);
-        internalCluster().startDataOnlyNode(settings);
+        internalCluster().startDataAndWarmNodes(1, settings);
         final Client clusterManagerClient = internalCluster().clusterManagerClient();
         ensureStableCluster(2);
 
@@ -222,7 +266,7 @@ public void testRemoteStoreCleanupForDeletedIndexForSnapshotV2MultipleSnapshots(
             .put(RemoteStoreSettings.CLUSTER_REMOTE_STORE_PATH_TYPE_SETTING.getKey(), RemoteStoreEnums.PathType.FIXED.toString())
             .build();
         String clusterManagerName = internalCluster().startClusterManagerOnlyNode(settings);
-        internalCluster().startDataOnlyNode(settings);
+        internalCluster().startDataAndWarmNodes(1, settings);
         final Client clusterManagerClient = internalCluster().clusterManagerClient();
         ensureStableCluster(2);
 
@@ -323,7 +367,7 @@ public void testRemoteStoreCleanupMultiplePrimaryOnSnapshotDeletion() throws Exc
             .put(RemoteStoreSettings.CLUSTER_REMOTE_STORE_PATH_TYPE_SETTING.getKey(), RemoteStoreEnums.PathType.FIXED.toString())
             .build();
         String clusterManagerName = internalCluster().startClusterManagerOnlyNode(settings);
-        internalCluster().startDataOnlyNodes(3, settings);
+        internalCluster().startDataAndWarmNodes(3, settings);
         final Client clusterManagerClient = internalCluster().clusterManagerClient();
         ensureStableCluster(4);
 
@@ -341,6 +385,7 @@ public void testRemoteStoreCleanupMultiplePrimaryOnSnapshotDeletion() throws Exc
         final String remoteStoreEnabledIndexName = "remote-index-1";
         final Settings remoteStoreEnabledIndexSettings = Settings.builder()
             .put(getRemoteStoreBackedIndexSettings())
+            .put(INDEX_DELAYED_NODE_LEFT_TIMEOUT_SETTING.getKey(), TimeValue.timeValueSeconds(0))
             .put(INDEX_REMOTE_TRANSLOG_KEEP_EXTRA_GEN_SETTING.getKey(), 2)
             .build();
         createIndex(remoteStoreEnabledIndexName, remoteStoreEnabledIndexSettings);