-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] The RestAction names should be templated otherwise the set of operations explodes #10791
Comments
@Gaganjuneja please let me know if you need help |
Hi, are we on track for this to be released in 2.12 ? |
Yes, Thanks! |
@atharvasharma61 Can you please take this up? |
@reta While I was trying to implement it, I came across certain sections where I need some clarity. For an instance, in the given query -
basically anything that is followed by '?' is a query param. I can add the rawPath in the spanName but there are two ways to add params in the tags -
Another thing to call out, |
…as tags and avoid using exact URI (opensearch-project#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com>
…as tags and avoid using exact URI (opensearch-project#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com>
* bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com>
…search-project#12005) * bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (opensearch-project#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com> (cherry picked from commit c0fca74)
…search-project#12005) * bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (opensearch-project#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com> (cherry picked from commit c0fca74)
…search-project#12005) * bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (opensearch-project#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com> (cherry picked from commit c0fca74)
…search-project#12005) * bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (opensearch-project#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com> (cherry picked from commit c0fca74)
…) (#12221) * bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com> (cherry picked from commit c0fca74)
…) (#12222) * bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com> (cherry picked from commit c0fca74)
…search-project#12005) * bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (opensearch-project#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com>
…search-project#12005) * bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (opensearch-project#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com>
…search-project#12005) * bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (opensearch-project#10791) Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added UTs Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added parameterized tests Signed-off-by: Atharva Sharma <athrv@amazon.com> * improvised parameterized tests using annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * removed unused annotations Signed-off-by: Atharva Sharma <athrv@amazon.com> * Added details in CHANGELOG.md Signed-off-by: Atharva Sharma <athrv@amazon.com> * Addressed spotlessJavaCheck failures Signed-off-by: Atharva Sharma <athrv@amazon.com> --------- Signed-off-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Atharva Sharma <athrv@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Describe the bug
Right now the RestAction spans are created out exact request URI which:
Here are couples of examples:
To Reproduce
For example:
curl http://localhost:9200/*/_search
curl http://localhost:9200/*/_search?track_total_hits=false
curl http://localhost:9200/test51/_search?track_total_hits=false
This calls will generate 3 unique operation names but is has to be only one:
GET /{indices}/_search
with other details of the invocation becoming the tags.Expected behavior
The operation names for RestAction has to be templated, otherwise the set of operations explodes and troubleshooting becomes unmanageable (like the simple example below has > 2k unique operation calls that should match to only ~20 APIs):
Plugins
OpenTelemetry
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):
Additional context
Add any other context about the problem here.
CC @Gaganjuneja this is yet another one
The text was updated successfully, but these errors were encountered: