Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging for the nodes with remote store attributes #10809

Closed
dhwanilpatel opened this issue Oct 21, 2023 · 1 comment
Closed

Fix logging for the nodes with remote store attributes #10809

dhwanilpatel opened this issue Oct 21, 2023 · 1 comment
Labels
enhancement Enhancement or improvement to existing feature or request untriaged

Comments

@dhwanilpatel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For Remote store enabled nodes, we add multiple remote store related attributes in node. Those all attributes are getting logged in logs when node's information is being logged.

It is creating too much noise in logs, and for the logs where multiple node's information is logged in single line it will be too long log lines.

Fix
We can redact the node attributes from the logs. We can remove those attribute from toString method of DiscoveryNode.

Meta issue: #10523

@dhwanilpatel dhwanilpatel added enhancement Enhancement or improvement to existing feature or request untriaged labels Oct 21, 2023
@dhwanilpatel dhwanilpatel changed the title Fix logging for the nodes with remote attributes Fix logging for the nodes with remote store attributes Oct 21, 2023
@linuxpi
Copy link
Collaborator

linuxpi commented Oct 30, 2023

Closing as #10810 is merged

@linuxpi linuxpi closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request untriaged
Projects
None yet
Development

No branches or pull requests

2 participants