Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiered Caching] Make took time caching policy setting dynamic #13062

Closed
sgup432 opened this issue Apr 3, 2024 · 1 comment · Fixed by #13063
Closed

[Tiered Caching] Make took time caching policy setting dynamic #13062

sgup432 opened this issue Apr 3, 2024 · 1 comment · Fixed by #13063
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance

Comments

@sgup432
Copy link
Contributor

sgup432 commented Apr 3, 2024

Is your feature request related to a problem? Please describe

As of now, we have a took time policy setting via which we determine whether we need to put an item into disk cache which got evicted from upper onHeap tier. This was needed so that we only cache queries into disk which are relatively slow and can gain benefit by having them in disk cache.

This is a static setting as of now, so we need to make this dynamic so that user can change it easily on the fly.

Describe the solution you'd like

  • Make static setting dynamic and desired changes required around that.
  • Add IT tests

Related component

Search:Performance

Describe alternatives you've considered

No response

Additional context

No response

@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6]
@sgup432 Thanks for filing, look forward to this improvement

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Apr 11, 2024
@sgup432 sgup432 moved this to In-Review in Performance Roadmap Apr 29, 2024
@sgup432 sgup432 moved this from In-Review to Done in Performance Roadmap May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants