[BUG] Use system prop `org.bouncycastle.native.cleanup_delay` with value 0 to disable BC cleanup for tests after upgrade to 2.1.2

[cwperks]

Describe the bug

Filing this issue as a follow-up to #19222. In that PR we introduce a BouncyCastleThreadFilter to let the test framework know to ignore bouncy castle threads for thread leak detection.

In the next release of bouncycastle (2.1.2), there will be a new system prop introduced to handle this automatically (org.bouncycastle.native.cleanup_delay: 0). I'm filing this issue to track the removal of BouncyCastleThreadFilter in favor of using the system prop.

Related component

Libraries

To Reproduce

N/A

Expected behavior

N/A

Additional Details

bcgit/bc-java#2121

[cwperks]

Bouncycastle may have actually changed the default value from 5s to 0s: https://github.com/bcgit/bc-lts-java/blob/main/core/src/main/java/org/bouncycastle/util/dispose/DisposalDaemon.java#L41

^ we may not need to pass the prop explicitly after upgrade to 2.1.2.

[krisfreedain]

Catch All Triage - 1 2

[dbwiddis]

Bouncycastle may have actually changed the default value from 5s to 0s: https://github.com/bcgit/bc-lts-java/blob/main/core/src/main/java/org/bouncycastle/util/dispose/DisposalDaemon.java#L41

^ we may not need to pass the prop explicitly after upgrade to 2.1.2.

@cwperks Tried the setting, see 024b994

Unfortunately that only prevents starting the "BC Cleanup Executor" thread. The "BC Disposal Daemon" thread still runs, and has a shutdown hook so thread leak detection is still going to alert on it.

Porting your "temporary" fix to the bc-fips PR on 2.19 to unblock 2.19.4 release fixes, but this looks to be a bit more complicated.

CC: @reta @andrross