Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameters to flat_object type #13853

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented May 28, 2024

Signed-off-by: kkewwei kkewwei@163.com

Description

The following open parameters setting are useful, including normalizer, docValues, ignoreAbove, nullValue, similarity, and depthlimit.

normalizer: allow lowercase, uppercase
doc_values: allow to set docValues to be false
index: allow to set index to be false
ignore_above: allow to set if the length of a field is go above certain limit then ignore the document.
similarity: allow to set similarity setting
depth_limit: allow to set maximum depth limitation to the JSON document

If there are other useful parameters, you are also welcome to give feedback or continue to add.

Related Issues

Resolves #7137

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request help wanted Extra attention is needed Search Search query, autocomplete ...etc labels May 28, 2024
@kkewwei kkewwei force-pushed the flat_object_para branch 2 times, most recently from 25c607c to 5bde254 Compare May 28, 2024 10:55
Copy link
Contributor

❌ Gradle check result for ec4d256: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 25c607c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the flat_object_para branch from 819ada8 to 2607e4b Compare May 28, 2024 11:10
Copy link
Contributor

❌ Gradle check result for 819ada8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Jun 30, 2024

@mingshl,it seems that only the null_value may affect the exist query, if here is not clear, I can temporarily rewind the logic: we should remove the sub key, when the the sub value is null.

Those unit tests add in FlatObjectFieldMapperTests.java and [106_flat_object_with_parameter.yml, including exception cases, if you have any cases, I'd be happy to add them.

@kkewwei
Copy link
Contributor Author

kkewwei commented Jun 30, 2024

@mingshl maybe we should first consider the case of null_value? #14069.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Jul 30, 2024
@kkewwei kkewwei mentioned this pull request Aug 27, 2024
8 tasks
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Sep 8, 2024
@kkewwei
Copy link
Contributor Author

kkewwei commented Sep 22, 2024

@msfroh I have a little doubt, please help confirm when you are free:

  • If we just support object value in flat_object field, do we need to support null_value?

  • If we do, null_value must be an object field?

Copy link
Contributor

github-actions bot commented Nov 4, 2024

❌ Gradle check result for 46c87c3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 4, 2024

❌ Gradle check result for a9f53b7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 4, 2024

❌ Gradle check result for 924f16d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 6, 2024

❌ Gradle check result for a9c30b8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 6, 2024

❌ Gradle check result for 2a3c1fc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: kkewwei <kkewwei@163.com>
Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ Gradle check result for f55800b: SUCCESS

@kkewwei
Copy link
Contributor Author

kkewwei commented Nov 7, 2024

@mingshl @msfroh, please have a look when you are free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request help wanted Extra attention is needed Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add Open Parameters to Flat_object Field Type
3 participants