-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add parameters to flat_object type #13853
base: main
Are you sure you want to change the base?
Conversation
25c607c
to
5bde254
Compare
❌ Gradle check result for ec4d256: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 25c607c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 819ada8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@mingshl,it seems that only the null_value may affect the exist query, if here is not clear, I can temporarily rewind the logic: we should remove the sub key, when the the sub value is null. Those unit tests add in FlatObjectFieldMapperTests.java and [106_flat_object_with_parameter.yml, including exception cases, if you have any cases, I'd be happy to add them. |
This PR is stalled because it has been open for 30 days with no activity. |
This PR is stalled because it has been open for 30 days with no activity. |
@msfroh I have a little doubt, please help confirm when you are free:
|
ea2bae8
to
46c87c3
Compare
❌ Gradle check result for 46c87c3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
46c87c3
to
a9f53b7
Compare
❌ Gradle check result for a9f53b7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a9f53b7
to
924f16d
Compare
❌ Gradle check result for 924f16d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
924f16d
to
a9c30b8
Compare
❌ Gradle check result for a9c30b8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a9c30b8
to
2a3c1fc
Compare
❌ Gradle check result for 2a3c1fc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <kkewwei@163.com>
2a3c1fc
to
f55800b
Compare
Signed-off-by: kkewwei kkewwei@163.com
Description
The following open parameters setting are useful, including normalizer, docValues, ignoreAbove, nullValue, similarity, and depthlimit.
normalizer: allow lowercase, uppercase
doc_values: allow to set docValues to be false
index: allow to set index to be false
ignore_above: allow to set if the length of a field is go above certain limit then ignore the document.
similarity: allow to set similarity setting
depth_limit: allow to set maximum depth limitation to the JSON document
If there are other useful parameters, you are also welcome to give feedback or continue to add.
Related Issues
Resolves #7137
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.