Retaining the old constructors for classes marked as API changed as part of #12333 #13926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art of opensearch-project#12333 Signed-off-by: Harsh Garg <gkharsh@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13926 +/- ##
============================================
+ Coverage 71.42% 71.70% +0.28%
- Complexity 59978 61680 +1702
============================================
Files 4985 5089 +104
Lines 282275 289429 +7154
Branches 40946 41859 +913
============================================
+ Hits 201603 207541 +5938
- Misses 63999 64759 +760
- Partials 16673 17129 +456 ☔ View full report in Codecov by Sentry. |
rajiv-kv
reviewed
Jun 5, 2024
server/src/main/java/org/opensearch/cluster/service/ClusterApplierService.java
Show resolved
Hide resolved
Signed-off-by: Harsh Garg <gkharsh@amazon.com>
rajiv-kv
approved these changes
Jun 7, 2024
gargharsh3134
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
sachinpkale
approved these changes
Jun 7, 2024
added 2 commits
June 8, 2024 17:25
Signed-off-by: Harsh Garg <gkharsh@amazon.com>
Signed-off-by: Harsh Garg <gkharsh@amazon.com>
|
❕ Gradle check result for 06ac829: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
sachinpkale
approved these changes
Jun 9, 2024
gargharsh3134
added a commit
to gargharsh3134/OpenSearch
that referenced
this pull request
Jun 10, 2024
…art of opensearch-project#12333 (opensearch-project#13926) * Retaining the old constructors for classes marked as API changed as part of opensearch-project#12333 --------- Signed-off-by: Harsh Garg <gkharsh@amazon.com> Co-authored-by: Harsh Garg <gkharsh@amazon.com>
gargharsh3134
added a commit
to gargharsh3134/OpenSearch
that referenced
this pull request
Jun 10, 2024
…art of opensearch-project#12333 (opensearch-project#13926) * Retaining the old constructors for classes marked as API changed as part of opensearch-project#12333 --------- Signed-off-by: Harsh Garg <gkharsh@amazon.com> Co-authored-by: Harsh Garg <gkharsh@amazon.com>
3 tasks
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…art of opensearch-project#12333 (opensearch-project#13926) * Retaining the old constructors for classes marked as API changed as part of opensearch-project#12333 --------- Signed-off-by: Harsh Garg <gkharsh@amazon.com> Co-authored-by: Harsh Garg <gkharsh@amazon.com>
This was referenced Jun 13, 2024
3 tasks
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…art of opensearch-project#12333 (opensearch-project#13926) * Retaining the old constructors for classes marked as API changed as part of opensearch-project#12333 --------- Signed-off-by: Harsh Garg <gkharsh@amazon.com> Co-authored-by: Harsh Garg <gkharsh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #12333, constructors of some of the classes marked as API were changed to add a new ClusterManagerMetrics parameter. This was causing failures in the respective backport PRs (#13755 for reference) because of breaking changes. This PR is targeted to retain those old constructors and maintain compatibility.
Related Issues
Resolves #14068
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.