Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute all flaky IndicesRequestCacheIT tests #14077

Merged

Conversation

andrross
Copy link
Member

@andrross andrross commented Jun 7, 2024

These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross
Copy link
Member Author

andrross commented Jun 7, 2024

@sgup432 @kiranprakash154 @getsaurabh02 Just FYI. It seems likely there are underlying bugs here, but as we have been just retrying the failures and shipping code anyway, I don't think these tests are really adding any value. We should fix these issues ASAP though because I believe this is mostly new flakiness introduced in the past few months.

These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross andrross force-pushed the mute-indicesrequestcache branch from a1ec22f to cf42dbd Compare June 7, 2024 18:55
Copy link
Contributor

github-actions bot commented Jun 7, 2024

✅ Gradle check result for cf42dbd: SUCCESS

@andrross andrross merged commit fbe048f into opensearch-project:main Jun 7, 2024
28 checks passed
@andrross andrross added the backport 2.x Backport to 2.x branch label Jun 7, 2024
@andrross andrross deleted the mute-indicesrequestcache branch June 7, 2024 20:44
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 7, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit fbe048f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Jun 10, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600


(cherry picked from commit fbe048f)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
@Pallavi-AWS
Copy link
Member

Pallavi-AWS commented Jun 11, 2024

@sgup432 @kiranprakash154 @getsaurabh02 Just FYI. It seems likely there are underlying bugs here, but as we have been just retrying the failures and shipping code anyway, I don't think these tests are really adding any value. We should fix these issues ASAP though because I believe this is mostly new flakiness introduced in the past few months.

hi @sgup432 - can you please confirm if we need these testcases? If yes, how can we remove the flakiness as soon as possible? Have we established that the tiered caching race condition being worked on by @kiranprakash154 would resolve a subset of these testcases? thanks.

@kiranprakash154
Copy link
Contributor

kiranprakash154 commented Jun 11, 2024

Hi @Pallavi-AWS and @andrross,
we do need these test cases, but they should never be flaky. The race condition I'm working on (#14032) is a separate issue and I dont think affects the flakiness of these tests.

I'll get to flaky tests right after resolving the race condition bug and have a fix soon.
(cc: @kkhatua @sgup432 )

@sgup432
Copy link
Contributor

sgup432 commented Jun 11, 2024

@Pallavi-AWS As @kiranprakash154 pointed out, we need these testcases. We are working on this separately to resolve all/most of these tests all at once.

andrross added a commit to andrross/OpenSearch that referenced this pull request Jun 12, 2024
…t#14077)"

This reverts commit fbe048f. Muting
these tests was only intended to be temporary to unblock the 2.15
release.

Signed-off-by: Andrew Ross <andrross@amazon.com>
reta pushed a commit that referenced this pull request Jun 12, 2024
This reverts commit fbe048f. Muting
these tests was only intended to be temporary to unblock the 2.15
release.

Signed-off-by: Andrew Ross <andrross@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 12, 2024
This reverts commit fbe048f. Muting
these tests was only intended to be temporary to unblock the 2.15
release.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 90ef844)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Jun 12, 2024
…#14239)

This reverts commit fbe048f. Muting
these tests was only intended to be temporary to unblock the 2.15
release.


(cherry picked from commit 90ef844)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
…t#14077)" (opensearch-project#14238)

This reverts commit fbe048f. Muting
these tests was only intended to be temporary to unblock the 2.15
release.

Signed-off-by: Andrew Ross <andrross@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…opensearch-project#14082)

These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

(cherry picked from commit fbe048f)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…t#14077)" (opensearch-project#14238) (opensearch-project#14239)

This reverts commit fbe048f. Muting
these tests was only intended to be temporary to unblock the 2.15
release.

(cherry picked from commit 90ef844)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…t#14077)" (opensearch-project#14238)

This reverts commit fbe048f. Muting
these tests was only intended to be temporary to unblock the 2.15
release.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants