Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ShardsBatchGatewayAllocator in batch enabled mode for shard… #14107

Merged

Conversation

SwethaGuptha
Copy link
Contributor

@SwethaGuptha SwethaGuptha commented Jun 10, 2024

Description

Change in AllocationService to switch to ShardsBatchGatewayAllocator for serving API _cluster/allocation/explain when batch mode is enabled.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
#13990

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 27a1e00: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

… explain allocation API

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
@SwethaGuptha SwethaGuptha force-pushed the async-bug-branch#13990 branch from 27a1e00 to 385dbe6 Compare June 10, 2024 11:23
Copy link
Contributor

❌ Gradle check result for 385dbe6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha
Copy link
Contributor Author

Failures:

[org.opensearch.indices.IndicesRequestCacheIT.testDynamicStalenessThresholdUpdate {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"false"}}](https://build.ci.opensearch.org/job/gradle-check/40439/testReport/junit/org.opensearch.indices/IndicesRequestCacheIT/testDynamicStalenessThresholdUpdate__p0___opensearch_experimental_feature_pluggable_caching_enabled___false___/)
    [org.opensearch.indices.IndicesRequestCacheIT.classMethod](https://build.ci.opensearch.org/job/gradle-check/40439/testReport/junit/org.opensearch.indices/IndicesRequestCacheIT/classMethod/)

Flaky test:

#13949

Copy link
Contributor

❌ Gradle check result for 385dbe6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 385dbe6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 385dbe6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha
Copy link
Contributor Author

Latest gradle run failure:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/40647/testReport/) (1 failure / ±0)

    [org.opensearch.indices.IndicesRequestCacheIT.testStaleKeysRemovalWithoutExplicitThreshold {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"false"}}](https://build.ci.opensearch.org/job/gradle-check/40647/testReport/junit/org.opensearch.indices/IndicesRequestCacheIT/testStaleKeysRemovalWithoutExplicitThreshold__p0___opensearch_experimental_feature_pluggable_caching_enabled___false___/)

flaky test: #14173

Copy link
Contributor

❌ Gradle check result for 385dbe6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 385dbe6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 385dbe6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha
Copy link
Contributor Author

❌ Gradle check result for 385dbe6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#14173

Copy link
Contributor

✅ Gradle check result for 385dbe6: SUCCESS

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (b15cb0c) to head (385dbe6).
Report is 404 commits behind head on main.

Files Patch % Lines
.../cluster/routing/allocation/AllocationService.java 25.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14107      +/-   ##
============================================
+ Coverage     71.42%   71.71%   +0.29%     
- Complexity    59978    61429    +1451     
============================================
  Files          4985     5073      +88     
  Lines        282275   288527    +6252     
  Branches      40946    41777     +831     
============================================
+ Hits         201603   206923    +5320     
- Misses        63999    64464     +465     
- Partials      16673    17140     +467     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 2e13e9c into opensearch-project:main Jun 12, 2024
35 of 39 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Jun 12, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 12, 2024
… explain allocation API (#14107)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
(cherry picked from commit 2e13e9c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Jun 12, 2024
… explain allocation API (#14107) (#14218)

(cherry picked from commit 2e13e9c)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 14, 2024
… explain allocation API (#14107)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
(cherry picked from commit 2e13e9c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Jun 14, 2024
… explain allocation API (#14107) (#14340)

(cherry picked from commit 2e13e9c)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
… explain allocation API (opensearch-project#14107)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
… explain allocation API (opensearch-project#14107) (opensearch-project#14218)

(cherry picked from commit 2e13e9c)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
… explain allocation API (opensearch-project#14107)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants