Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] ClusterManager metrics instrumentation changes #14118

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

gargharsh3134
Copy link
Contributor

@gargharsh3134 gargharsh3134 commented Jun 10, 2024

Description

This PR is targeted to backport clusterManager metrics instrumentation to 2.x branch. It has 4 commits cherry-picked from the following 4 PRs:
#12333
#12439
#13926
#14123

Related Issues

Resolves #14068

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 7b17c4d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 6d78faa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…rch-project#12333)

* Adds latency metrics for ClusterState Appliers and Listeners

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
…ch-project#12439)

* Adds counter metrics for leader and follower check failures

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
…art of opensearch-project#12333 (opensearch-project#13926)

* Retaining the old constructors for classes marked as API changed as part of opensearch-project#12333
---------
Signed-off-by: Harsh Garg <gkharsh@amazon.com>
Co-authored-by: Harsh Garg <gkharsh@amazon.com>
Copy link
Contributor

❌ Gradle check result for 76af84d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 13d5830: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 2850916: SUCCESS

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 87.32394% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.29%. Comparing base (0dd892c) to head (4d6dcc8).
Report is 330 commits behind head on 2.x.

Files Patch % Lines
.../org/opensearch/cluster/ClusterManagerMetrics.java 73.91% 4 Missing and 2 partials ⚠️
server/src/main/java/org/opensearch/node/Node.java 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14118      +/-   ##
============================================
+ Coverage     71.28%   71.29%   +0.01%     
- Complexity    60145    61602    +1457     
============================================
  Files          4957     5061     +104     
  Lines        282799   289627    +6828     
  Branches      41409    42266     +857     
============================================
+ Hits         201591   206498    +4907     
- Misses        64189    65697    +1508     
- Partials      17019    17432     +413     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ility

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
Copy link
Contributor

❌ Gradle check result for 4d6dcc8: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 4d6dcc8: SUCCESS

@sachinpkale sachinpkale merged commit 2a8ffba into opensearch-project:2.x Jun 10, 2024
55 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…-project#14118)

---------

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
Co-authored-by: Harsh Garg <gkharsh@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@gargharsh3134 gargharsh3134 deleted the 2.x branch September 10, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cluster Manager
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants