-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset discovery nodes in all transport node actions request. #15131
Merged
shwetathareja
merged 1 commit into
opensearch-project:main
from
SwethaGuptha:opensearch-remove-discovery-nodes
Sep 4, 2024
Merged
Reset discovery nodes in all transport node actions request. #15131
shwetathareja
merged 1 commit into
opensearch-project:main
from
SwethaGuptha:opensearch-remove-discovery-nodes
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Gradle check result for 596132b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
SwethaGuptha
force-pushed
the
opensearch-remove-discovery-nodes
branch
from
August 7, 2024 03:52
596132b
to
37f1988
Compare
❌ Gradle check result for 37f1988: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
SwethaGuptha
force-pushed
the
opensearch-remove-discovery-nodes
branch
2 times, most recently
from
August 7, 2024 16:45
7a53b7a
to
64ca9ba
Compare
SwethaGuptha
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
August 8, 2024 04:35
SwethaGuptha
force-pushed
the
opensearch-remove-discovery-nodes
branch
from
August 22, 2024 09:29
64ca9ba
to
96657b6
Compare
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 4, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
3 tasks
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 5, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 5, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
shwetathareja
pushed a commit
that referenced
this pull request
Sep 5, 2024
#15674) Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 5, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 5, 2024
…earch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 5, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
SwethaGuptha
pushed a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 5, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 6, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 6, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 6, 2024
…earch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
This was referenced Sep 6, 2024
SwethaGuptha
added a commit
to SwethaGuptha/OpenSearch
that referenced
this pull request
Sep 9, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com> Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
This was referenced Sep 11, 2024
shwetathareja
pushed a commit
that referenced
this pull request
Sep 12, 2024
… (#15681) Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
3 tasks
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…arch-project#15131) Signed-off-by: Swetha Guptha <gupthasg@amazon.com> Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation to #14749, we don't required discovery nodes information in most of the transport actions extending TransportNodesActions, hence un-setting the discovery nodes object for such action before sending transport request to individual nodes this will prevent unnecessary serialization/deserialization of the discovery nodes object.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#14713
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.