Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned enabled translog gc timestamp #15488

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

sachinpkale
Copy link
Member

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for ffd763b: SUCCESS

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 83.70787% with 29 lines in your changes missing coverage. Please review.

Project coverage is 71.97%. Comparing base (e982a16) to head (92cdb4a).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...rg/opensearch/index/translog/RemoteFsTranslog.java 81.34% 16 Missing and 9 partials ⚠️
...dex/translog/transfer/TranslogTransferManager.java 89.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15488      +/-   ##
============================================
+ Coverage     71.83%   71.97%   +0.13%     
- Complexity    63379    63520     +141     
============================================
  Files          5244     5244              
  Lines        296836   296975     +139     
  Branches      42860    42884      +24     
============================================
+ Hits         213243   213736     +493     
+ Misses        66082    65716     -366     
- Partials      17511    17523      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale force-pushed the pinned-enabled-translog-gc-timestamp branch from ffd763b to cffdf93 Compare August 29, 2024 09:58
Copy link
Contributor

❌ Gradle check result for cffdf93: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale force-pushed the pinned-enabled-translog-gc-timestamp branch from cffdf93 to e555e52 Compare August 30, 2024 07:20
Copy link
Contributor

❕ Gradle check result for e555e52: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sachinpkale sachinpkale force-pushed the pinned-enabled-translog-gc-timestamp branch from e555e52 to 92cdb4a Compare August 30, 2024 11:44
Copy link
Contributor

✅ Gradle check result for 92cdb4a: SUCCESS

@sachinpkale sachinpkale reopened this Sep 1, 2024
@sachinpkale sachinpkale force-pushed the pinned-enabled-translog-gc-timestamp branch from 92cdb4a to 54e32f5 Compare September 1, 2024 02:06
Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 92cdb4a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 54e32f5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for e57af3b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sachin Kale added 13 commits September 1, 2024 09:33
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
…nned timestamp is disabled

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
@sachinpkale sachinpkale force-pushed the pinned-enabled-translog-gc-timestamp branch from 229b6ac to 5651e01 Compare September 1, 2024 04:07
Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 229b6ac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 5651e01: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant