Add wait in replica recovery for allocation id to propagate on source node #15558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for fe22335: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
gbbafna
force-pushed
the
replica-wait
branch
from
fe22335 to
dc1afb5
Compare
|
❌ Gradle check result for dc1afb5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ashking94
reviewed
Sep 3, 2024
server/src/main/java/org/opensearch/indices/recovery/RecoverySourceHandler.java
Show resolved
Hide resolved
ashking94
reviewed
Sep 3, 2024
.../src/test/java/org/opensearch/indices/recovery/LocalStorePeerRecoverySourceHandlerTests.java
Show resolved
Hide resolved
ashking94
reviewed
Sep 3, 2024
.../src/test/java/org/opensearch/indices/recovery/LocalStorePeerRecoverySourceHandlerTests.java
Show resolved
Hide resolved
ashking94
requested changes
Sep 3, 2024
gbbafna
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 221243c: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15558 +/- ##
============================================
- Coverage 71.95% 71.94% -0.02%
- Complexity 64192 64197 +5
============================================
Files 5270 5271 +1
Lines 300052 300181 +129
Branches 43368 43384 +16
============================================
+ Hits 215917 215963 +46
- Misses 66442 66493 +51
- Partials 17693 17725 +32 ☔ View full report in Codecov by Sentry. |
ashking94
approved these changes
Sep 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
… node (#15558) * Add wait for target allocation id to appear Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * making waitForAssignment same Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Add more test Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 3c6019d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
… node (#15558) * Add wait for target allocation id to appear Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * making waitForAssignment same Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Add more test Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 3c6019d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 6, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
… node (opensearch-project#15558) * Add wait for target allocation id to appear Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * making waitForAssignment same Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Add more test Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
This was referenced Sep 11, 2024
Open
gbbafna
added a commit
that referenced
this pull request
Sep 26, 2024
… node (#15558) * Add wait for target allocation id to appear Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * making waitForAssignment same Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Add more test Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
… node (opensearch-project#15558) * Add wait for target allocation id to appear Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * making waitForAssignment same Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Add more test Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
… node (opensearch-project#15558) * Add wait for target allocation id to appear Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * making waitForAssignment same Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Add more test Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
… node (opensearch-project#15558) * Add wait for target allocation id to appear Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * making waitForAssignment same Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Add more test Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When remote cluster state is enabled, cluster state propagation might get delayed . This cause replica recoveries to fail complaining that
source node does not have the shard listed in its state as allocated on the node. This PR adds retry and backoff and gives some time for cluster state to get propagated and would prevent shards from failing due to same.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.