Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot V2] Fix for create snapshot build and test failures #15602

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

anshu1106
Copy link
Contributor

@anshu1106 anshu1106 commented Sep 3, 2024

Description

This is followup for #15124.

  1. This PR fixes :server:japicmp failure found during 2.x backport of the above PR.
Screenshot 2024-09-03 at 12 29 56 PM Screenshot 2024-09-03 at 12 29 45 PM
  1. With existing delimiter :, integ test fails with following error:
    https://build.ci.opensearch.org/job/gradle-check/46330/testReport/junit/org.opensearch.remotestore/RemoteRestoreSnapshotIT/testCreateSnapshotV2WithRedIndex/
    In this PR, we are changing the delimiter from : to __

Related Issues

Resolves #15123

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Snapshots labels Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for e773ee1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@anshu1106 anshu1106 changed the title [Snapshot V2] Add fix for :server:japicmp failure in 2.x backport [Snapshot V2] Add fix for :server:japicmp failure in 2.x backport and test failure Sep 3, 2024
@anshu1106 anshu1106 changed the title [Snapshot V2] Add fix for :server:japicmp failure in 2.x backport and test failure [Snapshot V2] Fix for create snapshot build and test failures Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 1936f24: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 67a41c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 462d62d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Anshu Agarwal added 2 commits September 3, 2024 14:33
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for e380db2: SUCCESS

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.84%. Comparing base (33be5a9) to head (9d2eb9b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/org/opensearch/snapshots/SnapshotInfo.java 0.00% 4 Missing ⚠️
.../org/opensearch/repositories/FilterRepository.java 0.00% 2 Missing ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15602      +/-   ##
============================================
- Coverage     71.99%   71.84%   -0.15%     
+ Complexity    63924    63870      -54     
============================================
  Files          5257     5257              
  Lines        298667   298675       +8     
  Branches      43184    43184              
============================================
- Hits         215028   214593     -435     
- Misses        65972    66453     +481     
+ Partials      17667    17629      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 4fc5ed0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for 9d2eb9b: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sachinpkale sachinpkale merged commit 70ba5a1 into opensearch-project:main Sep 3, 2024
32 of 34 checks passed
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
…arch-project#15602)

---------

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Sachin Kale <sachinpkale@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…arch-project#15602)

---------

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Sachin Kale <sachinpkale@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…arch-project#15602)

---------

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Sachin Kale <sachinpkale@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…arch-project#15602)

---------

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Sachin Kale <sachinpkale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Snapshots
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Snapshot-V2] Centralize snapshot creation and integrate with timestamp pinning
2 participants