-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Star Tree] Interfaces Fixes for Star Tree Search #15603
[Star Tree] Interfaces Fixes for Star Tree Search #15603
Conversation
❌ Gradle check result for 6c075c1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 4f9dea8: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
4f9dea8
to
6b67535
Compare
❌ Gradle check result for 6b67535: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
6b67535
to
bb4d53f
Compare
...rc/main/java/org/opensearch/index/compositeindex/datacube/startree/index/StarTreeValues.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
bb4d53f
to
08722e1
Compare
❌ Gradle check result for 08722e1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 08722e1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 08722e1: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15603 +/- ##
============================================
- Coverage 71.90% 71.37% -0.54%
+ Complexity 63869 63298 -571
============================================
Files 5257 5257
Lines 298675 298675
Branches 43184 43183 -1
============================================
- Hits 214775 213178 -1597
- Misses 66165 67864 +1699
+ Partials 17735 17633 -102 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 12f6493) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 12f6493) Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Description
This change allows the search flows to access StarTreeMetadata so that they can make a decision to cache the query or not based on segment max doc and number of star tree documents.
It also removes the assertion when the child node is not found so that we can gracefully handle the scenarios where we dimension value does not exist in the children.
Related Issues
Resolves #15604
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.