Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SnapshotV2] Add timestamp of last successful fetch of pinned timestamps in node stats #15611

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Sep 3, 2024

Description

This change adds the timestamp for the last successful fetch of pinned timestamps to the node stats:

  • We make use of the static method getPinnedTimestamps() of RemoteStorePinnedTimestampService. The first value of the returned tuple is when the last fetch of pinned timestamps is triggered . This is the timestamp we need to add to node stats.
  • We have ensured backward compatibility with version checks
  • We have added a new remote store specific metric class RemoteStoreNodeStats in the node stats

Related Issues

Resolves #15896

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 7500c9d: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ltaragi ltaragi self-assigned this Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 42a1030: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for a617c18: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for b238922: SUCCESS

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 48.57143% with 18 lines in your changes missing coverage. Please review.

Project coverage is 71.98%. Comparing base (d131d58) to head (b0a71d2).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...nsearch/node/remotestore/RemoteStoreNodeStats.java 45.00% 8 Missing and 3 partials ⚠️
...rch/action/admin/cluster/node/stats/NodeStats.java 44.44% 3 Missing and 2 partials ⚠️
...src/main/java/org/opensearch/node/NodeService.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15611      +/-   ##
============================================
+ Coverage     71.89%   71.98%   +0.09%     
- Complexity    64466    64528      +62     
============================================
  Files          5288     5289       +1     
  Lines        301439   301471      +32     
  Branches      43552    43558       +6     
============================================
+ Hits         216706   217011     +305     
+ Misses        66931    66676     -255     
+ Partials      17802    17784      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 7f81828: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Snapshots v2.18.0 Issues and PRs related to version 2.18.0 labels Sep 11, 2024
Copy link
Contributor

❌ Gradle check result for 7fae8db: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ltaragi
Copy link
Contributor Author

ltaragi commented Sep 11, 2024

❌ Gradle check result for 7fae8db: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test: #14316

Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Gradle check result for 4e42331: SUCCESS

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Gradle check result for b0a71d2: SUCCESS

@sachinpkale sachinpkale merged commit be9f942 into opensearch-project:main Oct 1, 2024
36 of 38 checks passed
hainenber pushed a commit to hainenber/OpenSearch that referenced this pull request Oct 1, 2024
…mps in node stats (opensearch-project#15611)

---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Oct 1, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 1, 2024
…mps in node stats (#15611)

---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit be9f942)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Oct 3, 2024
…mps in node stats (#15611)

---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit be9f942)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Oct 3, 2024
…mps in node stats (#15611) (#16155)

---------


(cherry picked from commit be9f942)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…mps in node stats (opensearch-project#15611)

---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…mps in node stats (opensearch-project#15611)

---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…mps in node stats (opensearch-project#15611)

---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
@dblock
Copy link
Member

dblock commented Oct 24, 2024

This needed an API spec change as remote_store is newly returned. Hitting it in opensearch-project/opensearch-api-specification#643.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Snapshots v2.18.0 Issues and PRs related to version 2.18.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[SnapshotV2] Add timestamp of last successful fetch of pinned timestamps in node stats
3 participants