-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SnapshotV2] Add timestamp of last successful fetch of pinned timestamps in node stats #15611
[SnapshotV2] Add timestamp of last successful fetch of pinned timestamps in node stats #15611
Conversation
❌ Gradle check result for 7500c9d: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
7500c9d
to
42a1030
Compare
❌ Gradle check result for 42a1030: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
42a1030
to
a617c18
Compare
❌ Gradle check result for a617c18: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a617c18
to
b238922
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15611 +/- ##
============================================
+ Coverage 71.89% 71.98% +0.09%
- Complexity 64466 64528 +62
============================================
Files 5288 5289 +1
Lines 301439 301471 +32
Branches 43552 43558 +6
============================================
+ Hits 216706 217011 +305
+ Misses 66931 66676 -255
+ Partials 17802 17784 -18 ☔ View full report in Codecov by Sentry. |
b238922
to
7f81828
Compare
❌ Gradle check result for 7f81828: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
7f81828
to
7fae8db
Compare
❌ Gradle check result for 7fae8db: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test: #14316 |
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeStats.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
…mps in node stats (opensearch-project#15611) --------- Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
…mps in node stats (#15611) (#16155) --------- (cherry picked from commit be9f942) Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…mps in node stats (opensearch-project#15611) --------- Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
…mps in node stats (opensearch-project#15611) --------- Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
…mps in node stats (opensearch-project#15611) --------- Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
This needed an API spec change as |
Description
This change adds the timestamp for the last successful fetch of pinned timestamps to the node stats:
getPinnedTimestamps()
ofRemoteStorePinnedTimestampService
. The first value of the returned tuple is when the last fetch of pinned timestamps is triggered . This is the timestamp we need to add to node stats.RemoteStoreNodeStats
in the node statsRelated Issues
Resolves #15896
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.