Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.17] Add new cluster setting for keyword indexordocvalues query (#15637) #15751

Merged
merged 4 commits into from
Sep 5, 2024
Merged

[Backport 2.17] Add new cluster setting for keyword indexordocvalues query (#15637) #15751

merged 4 commits into from
Sep 5, 2024

Conversation

harshavamsi
Copy link
Contributor

@harshavamsi harshavamsi commented Sep 5, 2024 •
edited
Loading

Description

Backport for #15703

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@harshavamsi
Add new cluster setting for keyword indexordocvalues query (opensearc…
f01f067 
…h-project#15637)

* Add new cluster setting for keyword indexordocvalues query

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

---------

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit d64baa6)
@harshavamsi
Update overload to fix breaking changes
e93b9fc 
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@harshavamsi harshavamsi changed the title Backport/backport 15637 to 2.17 [Backport 2.17] Add new cluster setting for keyword indexordocvalues query (#15637) Sep 5, 2024
@harshavamsi
Merge branch '2.17' into backport/backport-15637-to-2.17
eb41bda 
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for e93b9fc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for eb41bda: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi
Copy link
Contributor Author

❌ Gradle check result for eb41bda: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.index.reindex.DeleteByQueryBasicTests.testDeleteByQueryWithMultipleIndices
org.opensearch.index.reindex.DeleteByQueryBasicTests.testMultipleSources
org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode
org.opensearch.snapshots.DeleteSnapshotITV2.testRemoteStoreCleanupForDeletedIndexForSnapshotV2

More flaky tests :/

@msfroh msfroh mentioned this pull request Sep 5, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for eb41bda: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (75fb5bc) to head (0a980fc).
Report is 11 commits behind head on 2.17.

Files with missing lines Patch % Lines
...rg/opensearch/index/mapper/KeywordFieldMapper.java 70.00% 1 Missing and 2 partials ⚠️
.../org/opensearch/search/internal/SearchContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               2.17   #15751    +/-   ##
==========================================
  Coverage     71.66%   71.67%            
- Complexity    64317    64475   +158     
==========================================
  Files          5262     5263     +1     
  Lines        301148   301615   +467     
  Branches      43841    43913    +72     
==========================================
+ Hits         215829   216182   +353     
- Misses        67259    67335    +76     
- Partials      18060    18098    +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshavamsi
Merge branch '2.17' into backport/backport-15637-to-2.17
0a980fc 
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@harshavamsi harshavamsi mentioned this pull request Sep 5, 2024
Merged
3 tasks
@harshavamsi
Copy link
Contributor Author

#15771 -- should go in after this

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 0a980fc: SUCCESS

@msfroh msfroh merged commit 9f95932 into opensearch-project:2.17 Sep 5, 2024
35 of 37 checks passed
This was referenced Sep 6, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfroh msfroh msfroh approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshavamsi @msfroh