Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute flaky test testRemotePublicationDisabledByRollingRestart #15772

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Sep 5, 2024

Description

The test turned out to be flaky, so muting this for now. Would have reverted but this would cause conflict in PRs which need to be merged.

Related Issues

#15767

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for 3868b48: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.91%. Comparing base (375dda3) to head (3868b48).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15772      +/-   ##
============================================
- Coverage     71.96%   71.91%   -0.06%     
+ Complexity    64195    64172      -23     
============================================
  Files          5271     5271              
  Lines        300180   300180              
  Branches      43381    43381              
============================================
- Hits         216016   215860     -156     
- Misses        66444    66588     +144     
- Partials      17720    17732      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Sep 6, 2024
@shwetathareja shwetathareja merged commit 6f45a74 into opensearch-project:main Sep 6, 2024
63 of 64 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15772-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6f45a74765ecc77fcaed85721f6067a292e21162
# Push it to GitHub
git push --set-upstream origin backport/backport-15772-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15772-to-2.x.

@shiv0408 shiv0408 removed backport 2.x Backport to 2.x branch backport-failed labels Sep 6, 2024
@shiv0408 shiv0408 deleted the fix-15767 branch September 6, 2024 05:05
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants