-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize checksum creation for remote cluster state #16046
Conversation
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
❌ Gradle check result for 1b5edaa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/gateway/remote/ClusterStateChecksum.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @himshikha would you be able to share the perf numbers with this change
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
❌ Gradle check result for 542d709: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
❌ Gradle check result for 93f9a43: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test #14324 |
❌ Gradle check result for f14898c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
f14898c
to
989e4fe
Compare
❕ Gradle check result for 989e4fe: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16046-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a767e92f3eeaf57c066deb9ad075d40ed00f4a58
# Push it to GitHub
git push --set-upstream origin backport/backport-16046-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…ct#16046) * Support parallelisation in remote publication checksum computation Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Backport PR #16150 |
…ct#16046) * Support parallelisation in remote publication checksum computation Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
…ct#16046) * Support parallelisation in remote publication checksum computation Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
…ct#16046) * Support parallelisation in remote publication checksum computation Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Thanks @himshikha for this change. @Bukhtawar @himshikha - I think changes like this should have a |
…ct#16046) * Support parallelisation in remote publication checksum computation Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
…ct#16046) * Support parallelisation in remote publication checksum computation Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
…ct#16046) * Support parallelisation in remote publication checksum computation Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Description
This change parallelizes checksum creation for cluster state components, with the aim to reduce remote state publication latency.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.