Fix flaky test in RemoteStoreMigrationSettingsUpdateIT #16048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
>test-failure
ashking94
removed
>test-failure
ashking94
added
backport 2.x
github-actions
bot
added
>test-failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16048 +/- ##
============================================
+ Coverage 71.92% 71.97% +0.05%
+ Complexity 64400 64382 -18
============================================
Files 5281 5281
Lines 300995 300995
Branches 43479 43479
============================================
+ Hits 216491 216649 +158
+ Misses 66793 66530 -263
- Partials 17711 17816 +105 ☔ View full report in Codecov by Sentry. |
gbbafna
reviewed
Sep 24, 2024
...nalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationSettingsUpdateIT.java
Show resolved
Hide resolved
gbbafna
approved these changes
Sep 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit eeb2f39) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit eeb2f39) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruai0511
pushed a commit
to ruai0511/OpenSearch
that referenced
this pull request
Oct 4, 2024
…oject#16048) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…oject#16048) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…oject#16048) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…oject#16048) Signed-off-by: Ashish Singh <ssashish@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the failing test testNewRestoredIndexIsRemoteStoreBackedForRemoteStoreDirectionAndMixedMode. The fix has been achieved by adding the SNAPSHOT_SHARD_PATH_PREFIX_SETTING to the docrep node as well.
Related Issues
Resolves #15810
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.