Update version check in yaml test file for the bug fix of avoid infinite loop in flat_object parsing #16057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite loop in flat_object parsing Signed-off-by: Gao Binlong <gbinlong@amazon.com>
gaobinlong
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❕ Gradle check result for 7848791: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16057 +/- ##
============================================
- Coverage 71.92% 71.91% -0.01%
- Complexity 64400 64405 +5
============================================
Files 5281 5281
Lines 300995 300997 +2
Branches 43479 43479
============================================
- Hits 216491 216471 -20
+ Misses 66793 66775 -18
- Partials 17711 17751 +40 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 24, 2024
reta
approved these changes
Sep 24, 2024
reta
approved these changes
Sep 24, 2024
reta
pushed a commit
that referenced
this pull request
Sep 24, 2024
…ite loop in flat_object parsing (#16057) (#16064) (cherry picked from commit 848e5c6) Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 24, 2024
ruai0511
pushed a commit
to ruai0511/OpenSearch
that referenced
this pull request
Oct 4, 2024
…ite loop in flat_object parsing (opensearch-project#16057) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…ite loop in flat_object parsing (opensearch-project#16057) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…ite loop in flat_object parsing (opensearch-project#16057) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…ite loop in flat_object parsing (opensearch-project#16057) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this PR is backport to 2.x branch, we need to update the version check in the yaml test file from
2.99.99to2.17.99.Backport to 2.x is needed.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
- [ ] Functionality includes testing.
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.