-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant force merge in rest tests #16144
Conversation
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16144 +/- ##
============================================
+ Coverage 71.86% 72.01% +0.15%
- Complexity 64447 64492 +45
============================================
Files 5288 5288
Lines 301438 301439 +1
Branches 43552 43552
============================================
+ Hits 216628 217087 +459
+ Misses 67034 66489 -545
- Partials 17776 17863 +87 ☔ View full report in Codecov by Sentry. |
@jainankitk can you take a look? Per conversation here: #16083 (comment) |
Thanks @finnegancarroll for following up the discussion with this PR! |
Signed-off-by: Finn Carroll <carrofin@amazon.com> (cherry picked from commit a09750a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit a09750a) Signed-off-by: Finn Carroll <carrofin@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…6144) Signed-off-by: Finn Carroll <carrofin@amazon.com>
…6144) Signed-off-by: Finn Carroll <carrofin@amazon.com>
…6144) Signed-off-by: Finn Carroll <carrofin@amazon.com>
Description
Several aggregation rest tests assert on the number of optimized segments.
- match: { profile.shards.0.aggregations.0.debug.optimized_segments: 1 }
For these tests to be consistent our index can only have a single segment. As such we configure out test indices with 1 shard and no refresh interval to ensure a single segment.
We also force merge in these cases:
These two operations are redundant so this pr removes the force merge step for these cases.
Related Issues
Inciting comment
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.