Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant force merge in rest tests #16144

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

finnegancarroll
Copy link
Contributor

Description

Several aggregation rest tests assert on the number of optimized segments.
- match: { profile.shards.0.aggregations.0.debug.optimized_segments: 1 }

For these tests to be consistent our index can only have a single segment. As such we configure out test indices with 1 shard and no refresh interval to ensure a single segment.

settings:
  number_of_shards: 1
  number_of_replicas: 0
  refresh_interval: -1

We also force merge in these cases:

- do:
    indices.forcemerge:
      index: <index>
      max_num_segments: 1

These two operations are redundant so this pr removes the force merge step for these cases.

Related Issues

Inciting comment

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Finn Carroll <carrofin@amazon.com>
Copy link
Contributor

✅ Gradle check result for 7fa1d93: SUCCESS

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (8ddb3ee) to head (7fa1d93).
Report is 48 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16144      +/-   ##
============================================
+ Coverage     71.86%   72.01%   +0.15%     
- Complexity    64447    64492      +45     
============================================
  Files          5288     5288              
  Lines        301438   301439       +1     
  Branches      43552    43552              
============================================
+ Hits         216628   217087     +459     
+ Misses        67034    66489     -545     
- Partials      17776    17863      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@finnegancarroll
Copy link
Contributor Author

@jainankitk can you take a look? Per conversation here: #16083 (comment)

@jainankitk jainankitk added skip-changelog backport 2.x Backport to 2.x branch labels Oct 9, 2024
@jainankitk
Copy link
Collaborator

@jainankitk can you take a look? Per conversation here: #16083 (comment)

Thanks @finnegancarroll for following up the discussion with this PR!

@jainankitk jainankitk merged commit a09750a into opensearch-project:main Oct 9, 2024
64 of 66 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2024
Signed-off-by: Finn Carroll <carrofin@amazon.com>
(cherry picked from commit a09750a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Oct 14, 2024
(cherry picked from commit a09750a)

Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants