-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change version checks from CURRENT to 2.18 in #15611 #16174
Merged
sachinpkale
merged 1 commit into
opensearch-project:main
from
ltaragi:15611-version-change
Oct 3, 2024
Merged
Change version checks from CURRENT to 2.18 in #15611 #16174
sachinpkale
merged 1 commit into
opensearch-project:main
from
ltaragi:15611-version-change
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
ltaragi
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
October 3, 2024 05:26
sachinpkale
approved these changes
Oct 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com> (cherry picked from commit e7ad37d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16174 +/- ##
============================================
+ Coverage 71.91% 71.95% +0.04%
- Complexity 64491 64555 +64
============================================
Files 5289 5289
Lines 301509 301509
Branches 43557 43557
============================================
+ Hits 216818 216940 +122
+ Misses 66892 66772 -120
+ Partials 17799 17797 -2 ☔ View full report in Codecov by Sentry. |
sachinpkale
pushed a commit
that referenced
this pull request
Oct 3, 2024
(cherry picked from commit e7ad37d) Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the version checks from
Version.CURRENT
toVersion.V_2_18_0
for the changes introduced in #15611Check List
Functionality includes testing.API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.