Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version checks from CURRENT to 2.18 in #15611 #16174

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Oct 3, 2024

Description

This PR changes the version checks from Version.CURRENT to Version.V_2_18_0 for the changes introduced in #15611

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Copy link
Contributor

github-actions bot commented Oct 3, 2024

✅ Gradle check result for 24c950c: SUCCESS

@sachinpkale sachinpkale merged commit e7ad37d into opensearch-project:main Oct 3, 2024
59 of 60 checks passed
@ltaragi ltaragi added the backport 2.x Backport to 2.x branch label Oct 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2024
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit e7ad37d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.95%. Comparing base (4e3a6d0) to head (24c950c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rch/action/admin/cluster/node/stats/NodeStats.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16174      +/-   ##
============================================
+ Coverage     71.91%   71.95%   +0.04%     
- Complexity    64491    64555      +64     
============================================
  Files          5289     5289              
  Lines        301509   301509              
  Branches      43557    43557              
============================================
+ Hits         216818   216940     +122     
+ Misses        66892    66772     -120     
+ Partials      17799    17797       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sachinpkale pushed a commit that referenced this pull request Oct 3, 2024
(cherry picked from commit e7ad37d)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants