Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot V2] Use metadata from source snapshot while cloning snapshot V2 #16344

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Oct 16, 2024

Description

While cloning v2 snapshot, we need to use metadata from source snapshot. Earlier we were using cluster state metadata which would not have metadata for deleted indices.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Copy link
Contributor

❌ Gradle check result for e77aefe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for e77aefe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Copy link
Contributor

❌ Gradle check result for f36691d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…be null

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Copy link
Contributor

✅ Gradle check result for 833f327: SUCCESS

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 72.09%. Comparing base (35c366d) to head (833f327).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 0.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16344      +/-   ##
============================================
- Coverage     72.10%   72.09%   -0.02%     
+ Complexity    64862    64857       -5     
============================================
  Files          5307     5307              
  Lines        302606   302621      +15     
  Branches      43717    43719       +2     
============================================
- Hits         218208   218188      -20     
- Misses        66541    66546       +5     
- Partials      17857    17887      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 6594516 into opensearch-project:main Oct 16, 2024
37 of 38 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Oct 16, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 16, 2024
…t V2 (#16344)

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit 6594516)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…t V2 (opensearch-project#16344)

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Copy link
Contributor

❌ Gradle check result for e77aefe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dbwiddis pushed a commit that referenced this pull request Oct 17, 2024
…t V2 (#16344) (#16352)

---------


(cherry picked from commit 6594516)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…t V2 (opensearch-project#16344)

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…t V2 (opensearch-project#16344)

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants