Fix red index on close for remote enabled clusters #17521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Contributor
|
❌ Gradle check result for e2f81ce: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ashking94
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17521 +/- ##
============================================
- Coverage 72.59% 72.37% -0.22%
+ Complexity 65798 65650 -148
============================================
Files 5311 5311
Lines 304888 304890 +2
Branches 44212 44213 +1
============================================
- Hits 221323 220674 -649
- Misses 65501 66168 +667
+ Partials 18064 18048 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gbbafna
approved these changes
Mar 6, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit 342c645) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Mar 7, 2025
(cherry picked from commit 342c645) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Mar 18, 2025
…t#17521) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The check of comparing the max seq no and global checkpoint during bootstrap of ReadOnlyEngine for remote store enabled index is not required since the global checkpoint does not play a role with remote store. With a similar PR (#15990), changes were made to track the global checkpoint that has been updated as part of the successful translog upload to remote store. There are still cases where the global checkpoint appears to be changing locally but not getting updated on remote store.
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.